Un-inline requestPaintingResource in RenderSVGResource.cpp

Source/core/rendering/svg/RenderSVGResource.h

 /*
  * Copyright (C) Research In Motion Limited 2009-2010. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 57 matching lines @@
     Renderer* cast()
     {
         if (Renderer::s_resourceType == resourceType())
             return static_cast<Renderer*>(this);
 
         return 0;
     }
 
     // Helper utilities used in the render tree to access resources used for painting shapes/text (gradients & patterns & solid colors only)
     // If hasFallback gets set to true, the sharedSolidPaintingResource is set to a fallback color.
-    static RenderSVGResource* fillPaintingResource(RenderObject*, const RenderStyle*, bool& hasFallback);
-    static RenderSVGResource* strokePaintingResource(RenderObject*, const RenderStyle*, bool& hasFallback);
+    static RenderSVGResource* fillPaintingResource(RenderObject* object, const RenderStyle* style, bool& hasFallback)
+    {
+        return requestPaintingResource(ApplyToFillMode, object, style, hasFallback);
+    }
+    static RenderSVGResource* strokePaintingResource(RenderObject* object, const RenderStyle* style, bool& hasFallback)

[f(malita), 2014/09/12 14:17:52]

These wrappers seem to add little value. We should just drop them at some point
and have clients use requestPaintingResource + mode enum directly.

[fs, 2014/09/12 14:30:29]

Yeah, I've been thing along the same lines. I'll add it to my list.

+    {
+        return requestPaintingResource(ApplyToStrokeMode, object, style, hasFallback);
+    }
     static RenderSVGResourceSolidColor* sharedSolidPaintingResource();
 
     static void markForLayoutAndParentResourceInvalidation(RenderObject*, bool needsLayout = true);
+
+private:
+    static RenderSVGResource* requestPaintingResource(RenderSVGResourceMode, RenderObject*, const RenderStyle*, bool& hasFallback);
 };
 
 #define DEFINE_RENDER_SVG_RESOURCE_TYPE_CASTS(thisType, typeName) \
     DEFINE_TYPE_CASTS(thisType, RenderSVGResource, resource, resource->resourceType() == typeName, resource.resourceType() == typeName)
 
 }
 
 #endif