Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 563923006: [DevTools] Split network handling off ChromeDevToolsManagerDelegate to be reused on Android. (Closed)

Created:
6 years, 3 months ago by dgozman
Modified:
6 years, 3 months ago
Reviewers:
eustas, pfeldman
CC:
chromium-reviews, vsevik, yurys, paulirish+reviews_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Split network handling off ChromeDevToolsManagerDelegate to be reused on Android. BUG=none Committed: https://crrev.com/0bd04aebcbb49766fd04dc393f4c86747de754a8 Cr-Commit-Position: refs/heads/master@{#294798}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -153 lines) Patch
M chrome/browser/devtools/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/devtools/chrome_devtools_manager_delegate.h View 2 chunks +2 lines, -13 lines 0 comments Download
M chrome/browser/devtools/chrome_devtools_manager_delegate.cc View 2 chunks +4 lines, -96 lines 0 comments Download
A + chrome/browser/devtools/devtools_network_protocol_handler.h View 2 chunks +16 lines, -16 lines 0 comments Download
A + chrome/browser/devtools/devtools_network_protocol_handler.cc View 6 chunks +9 lines, -28 lines 0 comments Download
M chrome/chrome_debugger.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
dgozman
Could you please take a look? I'm introducing android-specific DevToolsManagerDelegate (https://codereview.chromium.org/560323005/) and would like to ...
6 years, 3 months ago (2014-09-12 13:08:15 UTC) #2
eustas
How would you pickup DevtoolsNetworkProtocolHandler on Android?
6 years, 3 months ago (2014-09-12 18:35:57 UTC) #3
eustas
lgtm
6 years, 3 months ago (2014-09-12 18:36:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/563923006/1
6 years, 3 months ago (2014-09-15 09:25:40 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as 011763d7226e56ced8cfb1a18b405b4c02ebdfa5
6 years, 3 months ago (2014-09-15 10:30:29 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-15 10:32:30 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0bd04aebcbb49766fd04dc393f4c86747de754a8
Cr-Commit-Position: refs/heads/master@{#294798}

Powered by Google App Engine
This is Rietveld 408576698