Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1787)

Unified Diff: chrome/browser/devtools/devtools_network_protocol_handler.h

Issue 563923006: [DevTools] Split network handling off ChromeDevToolsManagerDelegate to be reused on Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/devtools/devtools_network_protocol_handler.h
diff --git a/chrome/browser/devtools/chrome_devtools_manager_delegate.h b/chrome/browser/devtools/devtools_network_protocol_handler.h
similarity index 50%
copy from chrome/browser/devtools/chrome_devtools_manager_delegate.h
copy to chrome/browser/devtools/devtools_network_protocol_handler.h
index 98d464909e0f76ab08f18be3d64e032a555921a9..7dae6224be9dcf7b9ac3583a4b89a06499ecfe7e 100644
--- a/chrome/browser/devtools/chrome_devtools_manager_delegate.h
+++ b/chrome/browser/devtools/devtools_network_protocol_handler.h
@@ -2,31 +2,31 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef CHROME_BROWSER_DEVTOOLS_CHROME_DEVTOOLS_MANAGER_DELEGATE_H_
-#define CHROME_BROWSER_DEVTOOLS_CHROME_DEVTOOLS_MANAGER_DELEGATE_H_
+#ifndef CHROME_BROWSER_DEVTOOLS_DEVTOOLS_NETWORK_PROTOCOL_HANDLER_H_
+#define CHROME_BROWSER_DEVTOOLS_DEVTOOLS_NETWORK_PROTOCOL_HANDLER_H_
#include "base/compiler_specific.h"
#include "base/macros.h"
#include "base/memory/scoped_ptr.h"
#include "chrome/browser/devtools/devtools_protocol.h"
-#include "content/public/browser/devtools_manager_delegate.h"
+
+namespace content {
+class DevToolsAgentHost;
+}
class DevToolsNetworkConditions;
class Profile;
-class ChromeDevToolsManagerDelegate : public content::DevToolsManagerDelegate {
+class DevToolsNetworkProtocolHandler {
public:
- ChromeDevToolsManagerDelegate();
- virtual ~ChromeDevToolsManagerDelegate();
-
- // content::DevToolsManagerDelegate overrides:
- virtual void Inspect(content::BrowserContext* browser_context,
- content::DevToolsAgentHost* agent_host) OVERRIDE;
- virtual void DevToolsAgentStateChanged(content::DevToolsAgentHost* agent_host,
- bool attached) OVERRIDE;
- virtual base::DictionaryValue* HandleCommand(
+ DevToolsNetworkProtocolHandler();
+ ~DevToolsNetworkProtocolHandler();
+
+ void DevToolsAgentStateChanged(content::DevToolsAgentHost* agent_host,
+ bool attached);
+ base::DictionaryValue* HandleCommand(
content::DevToolsAgentHost* agent_host,
- base::DictionaryValue* command_dict) OVERRIDE;
+ base::DictionaryValue* command_dict);
private:
Profile* GetProfile(content::DevToolsAgentHost* agent_host);
@@ -43,7 +43,7 @@ class ChromeDevToolsManagerDelegate : public content::DevToolsManagerDelegate {
content::DevToolsAgentHost* agent_host,
scoped_ptr<DevToolsNetworkConditions> conditions);
- DISALLOW_COPY_AND_ASSIGN(ChromeDevToolsManagerDelegate);
+ DISALLOW_COPY_AND_ASSIGN(DevToolsNetworkProtocolHandler);
};
-#endif // CHROME_BROWSER_DEVTOOLS_CHROME_DEVTOOLS_MANAGER_DELEGATE_H_
+#endif // CHROME_BROWSER_DEVTOOLS_DEVTOOLS_NETWORK_PROTOCOL_HANDLER_H_

Powered by Google App Engine
This is Rietveld 408576698