Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(694)

Unified Diff: chrome/browser/devtools/devtools_network_protocol_handler.cc

Issue 563923006: [DevTools] Split network handling off ChromeDevToolsManagerDelegate to be reused on Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/devtools/devtools_network_protocol_handler.h ('k') | chrome/chrome_debugger.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/devtools/devtools_network_protocol_handler.cc
diff --git a/chrome/browser/devtools/chrome_devtools_manager_delegate.cc b/chrome/browser/devtools/devtools_network_protocol_handler.cc
similarity index 72%
copy from chrome/browser/devtools/chrome_devtools_manager_delegate.cc
copy to chrome/browser/devtools/devtools_network_protocol_handler.cc
index a7cd2f63e806cf6e5061cac3a3c02540d5810c35..d1151d2f2e8dbaebd121fc831235aabe222a4f1f 100644
--- a/chrome/browser/devtools/chrome_devtools_manager_delegate.cc
+++ b/chrome/browser/devtools/devtools_network_protocol_handler.cc
@@ -2,42 +2,23 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "chrome/browser/devtools/chrome_devtools_manager_delegate.h"
+#include "chrome/browser/devtools/devtools_network_protocol_handler.h"
#include "base/values.h"
#include "chrome/browser/devtools/devtools_network_conditions.h"
#include "chrome/browser/devtools/devtools_network_controller.h"
-#include "chrome/browser/devtools/devtools_protocol.h"
#include "chrome/browser/devtools/devtools_protocol_constants.h"
-#include "chrome/browser/devtools/devtools_window.h"
#include "chrome/browser/profiles/profile.h"
-#include "content/public/browser/browser_thread.h"
#include "content/public/browser/devtools_agent_host.h"
-#include "content/public/browser/render_process_host.h"
-#include "content/public/browser/render_view_host.h"
-#include "content/public/browser/site_instance.h"
#include "content/public/browser/web_contents.h"
-ChromeDevToolsManagerDelegate::ChromeDevToolsManagerDelegate() {
+DevToolsNetworkProtocolHandler::DevToolsNetworkProtocolHandler() {
}
-ChromeDevToolsManagerDelegate::~ChromeDevToolsManagerDelegate() {
+DevToolsNetworkProtocolHandler::~DevToolsNetworkProtocolHandler() {
}
-void ChromeDevToolsManagerDelegate::Inspect(
- content::BrowserContext* browser_context,
- content::DevToolsAgentHost* agent_host) {
- if (!agent_host->IsWorker()) {
- // TODO(horo): Support other types of DevToolsAgentHost when necessary.
- NOTREACHED() << "Inspect() only supports workers.";
- }
-#if !defined(OS_ANDROID)
- if (Profile* profile = Profile::FromBrowserContext(browser_context))
- DevToolsWindow::OpenDevToolsWindowForWorker(profile, agent_host);
-#endif
-}
-
-base::DictionaryValue* ChromeDevToolsManagerDelegate::HandleCommand(
+base::DictionaryValue* DevToolsNetworkProtocolHandler::HandleCommand(
content::DevToolsAgentHost* agent_host,
base::DictionaryValue* command_dict) {
scoped_ptr<DevToolsProtocol::Command> command(
@@ -60,7 +41,7 @@ base::DictionaryValue* ChromeDevToolsManagerDelegate::HandleCommand(
return NULL;
}
-Profile* ChromeDevToolsManagerDelegate::GetProfile(
+Profile* DevToolsNetworkProtocolHandler::GetProfile(
content::DevToolsAgentHost* agent_host) {
content::WebContents* web_contents = agent_host->GetWebContents();
if (!web_contents)
@@ -69,7 +50,7 @@ Profile* ChromeDevToolsManagerDelegate::GetProfile(
}
scoped_ptr<DevToolsProtocol::Response>
-ChromeDevToolsManagerDelegate::CanEmulateNetworkConditions(
+DevToolsNetworkProtocolHandler::CanEmulateNetworkConditions(
content::DevToolsAgentHost* agent_host,
DevToolsProtocol::Command* command) {
base::DictionaryValue* result = new base::DictionaryValue();
@@ -78,7 +59,7 @@ ChromeDevToolsManagerDelegate::CanEmulateNetworkConditions(
}
scoped_ptr<DevToolsProtocol::Response>
-ChromeDevToolsManagerDelegate::EmulateNetworkConditions(
+DevToolsNetworkProtocolHandler::EmulateNetworkConditions(
content::DevToolsAgentHost* agent_host,
DevToolsProtocol::Command* command) {
base::DictionaryValue* params = command->params();
@@ -114,7 +95,7 @@ ChromeDevToolsManagerDelegate::EmulateNetworkConditions(
return command->SuccessResponse(NULL);
}
-void ChromeDevToolsManagerDelegate::UpdateNetworkState(
+void DevToolsNetworkProtocolHandler::UpdateNetworkState(
content::DevToolsAgentHost* agent_host,
scoped_ptr<DevToolsNetworkConditions> conditions) {
Profile* profile = GetProfile(agent_host);
@@ -124,7 +105,7 @@ void ChromeDevToolsManagerDelegate::UpdateNetworkState(
agent_host->GetId(), conditions.Pass());
}
-void ChromeDevToolsManagerDelegate::DevToolsAgentStateChanged(
+void DevToolsNetworkProtocolHandler::DevToolsAgentStateChanged(
content::DevToolsAgentHost* agent_host,
bool attached) {
scoped_ptr<DevToolsNetworkConditions> conditions;
« no previous file with comments | « chrome/browser/devtools/devtools_network_protocol_handler.h ('k') | chrome/chrome_debugger.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698