Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 563183003: [Android] memory_inspector: add resident memory accounting. (Closed)

Created:
6 years, 3 months ago by Primiano Tucci (use gerrit)
Modified:
6 years, 3 months ago
Reviewers:
bccheng, hajimehoshi
CC:
chromium-reviews, darin-cc_chromium.org, jam, paulwhitton, Dai Mikurube (NOT FULLTIME)
Base URL:
https://chromium.googlesource.com/chromium/src.git@mi4
Project:
chromium
Visibility:
Public.

Description

[Android] memory_inspector: add resident memory accounting. Introduce the logic which is able to intersect mmap stats (dirty/clean priv/shared) with allocations. Essentially it contains the math to calculate the overlap (even partial) between allocations and mmaps and attribute stats counters to allocations. For the moment only resident memory is accounted. Finer grained accounting (dirty/clean) requires some changes to memdump (to have more than one bit per page in its output bitmap) and will come soon. BUG=340294 NOTRY=true Committed: https://crrev.com/786950036c44447667426bb07a51b911531ccc79 Cr-Commit-Position: refs/heads/master@{#295032}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+276 lines, -48 lines) Patch
M tools/memory_inspector/memory_inspector/backends/android/android_backend.py View 3 chunks +5 lines, -2 lines 0 comments Download
M tools/memory_inspector/memory_inspector/backends/android/android_backend_unittest.py View 2 chunks +3 lines, -2 lines 0 comments Download
M tools/memory_inspector/memory_inspector/classification/native_heap_classifier.py View 2 chunks +3 lines, -2 lines 0 comments Download
M tools/memory_inspector/memory_inspector/classification/native_heap_classifier_unittest.py View 4 chunks +23 lines, -23 lines 0 comments Download
M tools/memory_inspector/memory_inspector/core/native_heap.py View 2 chunks +65 lines, -5 lines 0 comments Download
A tools/memory_inspector/memory_inspector/core/native_heap_unittest.py View 1 chunk +147 lines, -0 lines 0 comments Download
M tools/memory_inspector/memory_inspector/core/stacktrace.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/memory_inspector/memory_inspector/data/serialization.py View 1 chunk +2 lines, -1 line 0 comments Download
M tools/memory_inspector/memory_inspector/frontends/background_tasks.py View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/memory_inspector/memory_inspector/frontends/www_content/index.html View 1 chunk +8 lines, -4 lines 0 comments Download
M tools/memory_inspector/memory_inspector/frontends/www_content/js/nheap.js View 3 chunks +16 lines, -7 lines 0 comments Download
M tools/memory_inspector/memory_inspector/frontends/www_server.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
Primiano Tucci (use gerrit)
Hello Guys, could you PTAL to this other one. This is piece to intersect the ...
6 years, 3 months ago (2014-09-12 11:00:10 UTC) #4
bccheng
lgtm
6 years, 3 months ago (2014-09-15 01:18:24 UTC) #5
bccheng
lgtm
6 years, 3 months ago (2014-09-15 01:18:28 UTC) #6
hajimehoshi
lgtm
6 years, 3 months ago (2014-09-16 02:14:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/563183003/40001
6 years, 3 months ago (2014-09-16 08:49:06 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:40001) as cead3aa83b120c61c9b0fb1d68f6282faf224e09
6 years, 3 months ago (2014-09-16 08:50:20 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-16 08:51:44 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/786950036c44447667426bb07a51b911531ccc79
Cr-Commit-Position: refs/heads/master@{#295032}

Powered by Google App Engine
This is Rietveld 408576698