tools/memory_inspector/memory_inspector/classification/native_heap_classifier.py - Issue 563183003: [Android] memory_inspector: add resident memory accounting.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/memory_inspector/memory_inspector/classification/native_heap_classifier.py

Issue 563183003: [Android] memory_inspector: add resident memory accounting. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mi4

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/memory_inspector/memory_inspector/backends/android/android_backend_unittest.py ('k') | tools/memory_inspector/memory_inspector/classification/native_heap_classifier_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/memory_inspector/memory_inspector/classification/native_heap_classifier.py

diff --git a/tools/memory_inspector/memory_inspector/classification/native_heap_classifier.py b/tools/memory_inspector/memory_inspector/classification/native_heap_classifier.py

index d51117cd73a3543feb3307398f332a059cce962c..e424afc4845627be4f8aeae31a6a907d69c872ab 100644

--- a/tools/memory_inspector/memory_inspector/classification/native_heap_classifier.py

+++ b/tools/memory_inspector/memory_inspector/classification/native_heap_classifier.py

@@ -34,7 +34,7 @@ from memory_inspector.core import exceptions

from memory_inspector.core import native_heap

-_RESULT_KEYS = ['bytes_allocated']

+_RESULT_KEYS = ['bytes_allocated', 'bytes_resident']

def LoadRules(content):

@@ -61,7 +61,8 @@ def Classify(nativeheap, rule_tree):

res = results.AggreatedResults(rule_tree, _RESULT_KEYS)

for allocation in nativeheap.allocations:

- res.AddToMatchingNodes(allocation, [allocation.size])

+ res.AddToMatchingNodes(allocation,

+ [allocation.size, allocation.resident_size])

return res