tools/memory_inspector/memory_inspector/backends/android/android_backend_unittest.py - Issue 563183003: [Android] memory_inspector: add resident memory accounting.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/memory_inspector/memory_inspector/backends/android/android_backend_unittest.py

Issue 563183003: [Android] memory_inspector: add resident memory accounting. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mi4

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/memory_inspector/memory_inspector/backends/android/android_backend.py ('k') | tools/memory_inspector/memory_inspector/classification/native_heap_classifier.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/memory_inspector/memory_inspector/backends/android/android_backend_unittest.py

diff --git a/tools/memory_inspector/memory_inspector/backends/android/android_backend_unittest.py b/tools/memory_inspector/memory_inspector/backends/android/android_backend_unittest.py

index 9a843c4ed531eb552b6627a68352e33cf856532d..29cfae33fa89e18176f68c3e70f21e21ea96ccc9 100644

--- a/tools/memory_inspector/memory_inspector/backends/android/android_backend_unittest.py

+++ b/tools/memory_inspector/memory_inspector/backends/android/android_backend_unittest.py

@@ -81,6 +81,7 @@ class AndroidBackendTest(unittest.TestCase):

'devices': _MOCK_DEVICES_OUT,

'shell getprop ro.product.model': 'Mock device',

'shell getprop ro.build.type': 'userdebug',

+ 'shell getprop ro.build.id': 'ZZ007',

'shell getprop ro.product.cpu.abi': 'armeabi',

'root': 'adbd is already running as root',

'shell /data/local/tmp/ps_ext': _MOCK_PS_EXT_OUT,

@@ -103,9 +104,9 @@ class AndroidBackendTest(unittest.TestCase):

# Test device enumeration.

devices = list(ab.EnumerateDevices())

self.assertEqual(len(devices), 2)

- self.assertEqual(devices[0].name, 'Mock device')

+ self.assertEqual(devices[0].name, 'Mock device ZZ007')

self.assertEqual(devices[0].id, '0000000000000001')

- self.assertEqual(devices[1].name, 'Mock device')

+ self.assertEqual(devices[1].name, 'Mock device ZZ007')

self.assertEqual(devices[1].id, '0000000000000002')

# Initialize device (checks that sha1 are checked in).