Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(761)

Issue 563163002: IDL: Fix build bugs in IDL dictionary impl generation (Closed)

Created:
6 years, 3 months ago by bashi
Modified:
6 years, 3 months ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

IDL: Fix build bugs in IDL dictionary impl generation - bindings_core_dictionary_impl_generated target should have core_dictionary_idl_files as inputs, otherwise IDL dictionaries impl classes won't get re-generated when they are edited. - impl_includes_for_type() should check idl_type.base_type (not idl_type.name), otherwise the CG won't include necessary header files for nullable interface members. BUG=321462 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181884

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -2 lines) Patch
M Source/bindings/core/v8/generated.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/scripts/v8_types.py View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/idls/core/TestDictionary.idl View 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/tests/results/core/TestDictionary.h View 3 chunks +5 lines, -0 lines 0 comments Download
M Source/bindings/tests/results/core/TestDictionary.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestDictionary.cpp View 1 3 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
bashi
Haraken-san, PTAL?
6 years, 3 months ago (2014-09-12 03:32:25 UTC) #2
haraken
LGTM
6 years, 3 months ago (2014-09-12 03:36:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/563163002/1
6 years, 3 months ago (2014-09-12 04:10:07 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/26750)
6 years, 3 months ago (2014-09-12 05:09:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/563163002/20001
6 years, 3 months ago (2014-09-12 05:16:21 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/26757)
6 years, 3 months ago (2014-09-12 07:25:47 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/563163002/20001
6 years, 3 months ago (2014-09-12 07:27:49 UTC) #13
commit-bot: I haz the power
6 years, 3 months ago (2014-09-12 08:04:10 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 181884

Powered by Google App Engine
This is Rietveld 408576698