Source/bindings/scripts/v8_types.py - Issue 563163002: IDL: Fix build bugs in IDL dictionary impl generation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/v8_types.py

Issue 563163002: IDL: Fix build bugs in IDL dictionary impl generation (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: rebase Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/scripts/v8_types.py

diff --git a/Source/bindings/scripts/v8_types.py b/Source/bindings/scripts/v8_types.py

index 746bf9c15d680356c88b8995b056cb81fce76e99..2ae989e49e4c45bf47bfeb76a814eaf0cfd8f970 100644

--- a/Source/bindings/scripts/v8_types.py

+++ b/Source/bindings/scripts/v8_types.py

@@ -422,8 +422,8 @@ def impl_includes_for_type(idl_type, interfaces_info):

if idl_type.is_string_type:

includes_for_type.add('wtf/text/WTFString.h')

- if idl_type.name in interfaces_info:

- interface_info = interfaces_info[idl_type.name]

+ if idl_type.base_type in interfaces_info:

+ interface_info = interfaces_info[idl_type.base_type]

includes_for_type.add(interface_info['include_path'])

return includes_for_type

« no previous file with comments | « Source/bindings/core/v8/generated.gyp ('k') | Source/bindings/tests/idls/core/TestDictionary.idl » ('j') | no next file with comments »