Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Side by Side Diff: Source/bindings/scripts/v8_types.py

Issue 563163002: IDL: Fix build bugs in IDL dictionary impl generation (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: rebase Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright (C) 2013 Google Inc. All rights reserved. 1 # Copyright (C) 2013 Google Inc. All rights reserved.
2 # 2 #
3 # Redistribution and use in source and binary forms, with or without 3 # Redistribution and use in source and binary forms, with or without
4 # modification, are permitted provided that the following conditions are 4 # modification, are permitted provided that the following conditions are
5 # met: 5 # met:
6 # 6 #
7 # * Redistributions of source code must retain the above copyright 7 # * Redistributions of source code must retain the above copyright
8 # notice, this list of conditions and the following disclaimer. 8 # notice, this list of conditions and the following disclaimer.
9 # * Redistributions in binary form must reproduce the above 9 # * Redistributions in binary form must reproduce the above
10 # copyright notice, this list of conditions and the following disclaimer 10 # copyright notice, this list of conditions and the following disclaimer
(...skipping 404 matching lines...) Expand 10 before | Expand all | Expand 10 after
415 415
416 idl_type = idl_type.preprocessed_type 416 idl_type = idl_type.preprocessed_type
417 native_array_element_type = idl_type.native_array_element_type 417 native_array_element_type = idl_type.native_array_element_type
418 if native_array_element_type: 418 if native_array_element_type:
419 includes_for_type.update(impl_includes_for_type( 419 includes_for_type.update(impl_includes_for_type(
420 native_array_element_type, interfaces_info)) 420 native_array_element_type, interfaces_info))
421 includes_for_type.add('wtf/Vector.h') 421 includes_for_type.add('wtf/Vector.h')
422 422
423 if idl_type.is_string_type: 423 if idl_type.is_string_type:
424 includes_for_type.add('wtf/text/WTFString.h') 424 includes_for_type.add('wtf/text/WTFString.h')
425 if idl_type.name in interfaces_info: 425 if idl_type.base_type in interfaces_info:
426 interface_info = interfaces_info[idl_type.name] 426 interface_info = interfaces_info[idl_type.base_type]
427 includes_for_type.add(interface_info['include_path']) 427 includes_for_type.add(interface_info['include_path'])
428 return includes_for_type 428 return includes_for_type
429 429
430 IdlTypeBase.impl_includes_for_type = impl_includes_for_type 430 IdlTypeBase.impl_includes_for_type = impl_includes_for_type
431 431
432 432
433 component_dir = {} 433 component_dir = {}
434 434
435 435
436 def set_component_dirs(new_component_dirs): 436 def set_component_dirs(new_component_dirs):
(...skipping 384 matching lines...) Expand 10 before | Expand all | Expand 10 after
821 821
822 822
823 def is_explicit_nullable(idl_type): 823 def is_explicit_nullable(idl_type):
824 # Nullable type that isn't implicit nullable (see above.) For such types, 824 # Nullable type that isn't implicit nullable (see above.) For such types,
825 # we use Nullable<T> or similar explicit ways to represent a null value. 825 # we use Nullable<T> or similar explicit ways to represent a null value.
826 return idl_type.is_nullable and not idl_type.is_implicit_nullable 826 return idl_type.is_nullable and not idl_type.is_implicit_nullable
827 827
828 IdlTypeBase.is_implicit_nullable = property(is_implicit_nullable) 828 IdlTypeBase.is_implicit_nullable = property(is_implicit_nullable)
829 IdlUnionType.is_implicit_nullable = False 829 IdlUnionType.is_implicit_nullable = False
830 IdlTypeBase.is_explicit_nullable = property(is_explicit_nullable) 830 IdlTypeBase.is_explicit_nullable = property(is_explicit_nullable)
OLDNEW
« no previous file with comments | « Source/bindings/core/v8/generated.gyp ('k') | Source/bindings/tests/idls/core/TestDictionary.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698