Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 563093003: Fix Mac password bubble crash due to the "nope" menu hanging around. (Closed)

Created:
6 years, 3 months ago by dconnelly
Modified:
6 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix Mac password bubble crash due to the "nope" menu hanging around. By default open menus in Cocoa exist until the user makes a choice, but since the bubble and its backing controller are owned and managed by cross-platform code, this model doesn't make sense. Hiding the menu programmatically matches the Views implementation and fixes the crash. Since triggering the NSPopUpButton's menu with |performClick:| spins a run loop waiting for user input, getting a test working was extremely difficult. The solution is to refactor BubbleCombobox to subclass MenuButton instead of NSPopUpButton; http://crbug.com/415088 created to track this work, which will then support a test for this bug. BUG=413267 Committed: https://crrev.com/0912e40030390bd3cc20b955ebc57c02dbe6fb5a Cr-Commit-Position: refs/heads/master@{#296398}

Patch Set 1 #

Messages

Total messages: 9 (3 generated)
dconnelly
6 years, 3 months ago (2014-09-17 11:43:55 UTC) #3
dconnelly
friendly ping
6 years, 3 months ago (2014-09-23 16:19:19 UTC) #4
rohitrao (ping after 24h)
LGTM Sorry, for some reason I thought this was already landed.
6 years, 3 months ago (2014-09-24 11:44:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/563093003/20001
6 years, 3 months ago (2014-09-24 11:46:46 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:20001) as df91b46e99a36c56a0c544b1baede71639581e42
6 years, 3 months ago (2014-09-24 12:53:08 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-24 12:53:38 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0912e40030390bd3cc20b955ebc57c02dbe6fb5a
Cr-Commit-Position: refs/heads/master@{#296398}

Powered by Google App Engine
This is Rietveld 408576698