Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5512)

Unified Diff: chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_pending_view_controller.mm

Issue 563093003: Fix Mac password bubble crash due to the "nope" menu hanging around. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_controller.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_pending_view_controller.mm
diff --git a/chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_pending_view_controller.mm b/chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_pending_view_controller.mm
index bfa5a69928a4340f131fdbf3b8a96d7c540a599d..2a978bbb1129a0e09828104b41fe6ca9d718769a 100644
--- a/chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_pending_view_controller.mm
+++ b/chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_pending_view_controller.mm
@@ -35,6 +35,13 @@ using namespace password_manager::mac::ui;
return self;
}
+- (void)bubbleWillDisappear {
+ // The "nope" drop-down won't be dismissed until the user chooses an option,
+ // but if the bubble is dismissed (by cross-platform code) before the user
+ // makes a choice, then the choice won't actually take any effect.
+ [[nopeButton_ menu] cancelTrackingWithoutAnimation];
+}
+
- (void)onSaveClicked:(id)sender {
model_->OnSaveClicked();
[delegate_ viewShouldDismiss];
« no previous file with comments | « chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_controller.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698