chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_controller.mm - Issue 563093003: Fix Mac password bubble crash due to the "nope" menu hanging around.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_controller.mm

Issue 563093003: Fix Mac password bubble crash due to the "nope" menu hanging around. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_controller.h ('k') | chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_pending_view_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_controller.mm

diff --git a/chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_controller.mm b/chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_controller.mm

index 1f6b53570d477116a8ea93662e7d7191b8979fb8..b3be40463009b4e9af0d884189ff977a91df6c6b 100644

--- a/chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_controller.mm

+++ b/chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_controller.mm

@@ -42,6 +42,11 @@

[super showWindow:sender];

}

+- (void)close {

+ [currentController_ bubbleWillDisappear];

+ [super close];

- (void)updateState {

// Find the next view controller.

currentController_.reset();