Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 562383002: gn: various flag matching for 'base' (Closed)

Created:
6 years, 3 months ago by scottmg
Modified:
6 years, 3 months ago
Reviewers:
brettw
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

gn: various gyp flag matching for 'base' - Don't remove -fno-ident from gyp build (was added about 3y ago, seemingly unnecessary for current clang) - Add -fno-slp-vectorize to GN to make builds match (both to be removed after next clang roll) - Make usage of -Wno-reserved-user-defined-literal match (required for dbus pre-trusty) - Add -march=x86-64 to gn cflags - Default symbol_level based on is_debug, and turn it off by default in Release (same as gyp) Also, fiddle with output of gyp_flag_compare.py. R=brettw@chromium.org BUG=335824 Committed: https://crrev.com/29682b848742042388ebd29c9df775f074c1414c Cr-Commit-Position: refs/heads/master@{#294489}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : symbols #

Patch Set 4 : . #

Patch Set 5 : back to g2/g0 #

Patch Set 6 : normalize -gs #

Patch Set 7 : default off only for linux #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -12 lines) Patch
M build/common.gypi View 1 chunk +0 lines, -3 lines 0 comments Download
M build/config/BUILDCONFIG.gn View 1 2 3 4 5 6 2 chunks +13 lines, -1 line 0 comments Download
M build/config/compiler/BUILD.gn View 1 3 4 3 chunks +12 lines, -7 lines 0 comments Download
M tools/gn/bin/gyp_flag_compare.py View 1 2 3 4 5 6 chunks +49 lines, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
scottmg
6 years, 3 months ago (2014-09-11 20:39:03 UTC) #5
scottmg
thakis: As punishment for being helpful you've been upgraded to a full reviewer!
6 years, 3 months ago (2014-09-11 22:06:44 UTC) #7
scottmg
(for BUILDCONFIG.gn)
6 years, 3 months ago (2014-09-11 22:07:03 UTC) #8
brettw
lgtm
6 years, 3 months ago (2014-09-11 22:49:12 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/562383002/180001
6 years, 3 months ago (2014-09-11 23:22:35 UTC) #11
scottmg
Committed patchset #7 (id:180001) to pending queue manually as fc54cb5 (presubmit successful).
6 years, 3 months ago (2014-09-11 23:29:05 UTC) #12
commit-bot: I haz the power
6 years, 3 months ago (2014-09-11 23:32:13 UTC) #13
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/29682b848742042388ebd29c9df775f074c1414c
Cr-Commit-Position: refs/heads/master@{#294489}

Powered by Google App Engine
This is Rietveld 408576698