Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Unified Diff: build/config/compiler/BUILD.gn

Issue 562383002: gn: various flag matching for 'base' (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: default off only for linux Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/config/BUILDCONFIG.gn ('k') | tools/gn/bin/gyp_flag_compare.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/compiler/BUILD.gn
diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
index 1e8da2d700d3bf7a3035d871983440f41bb828c2..d66f54c57a0c84cbe2f44c46f87d35a3d74eb599 100644
--- a/build/config/compiler/BUILD.gn
+++ b/build/config/compiler/BUILD.gn
@@ -103,6 +103,14 @@ config("compiler") {
}
}
+ if (is_clang) {
+ cflags += [
+ # TODO(thakis): Remove once http://llvm.org/PR20354 is fixed
+ # and the fix is in chromium.
+ "-fno-slp-vectorize",
+ ]
+ }
+
if (is_clang && !is_win) {
# This is here so that all files get recompiled after a clang roll and
# when turning clang on or off. (defines are passed via the command line,
@@ -150,7 +158,7 @@ config("compiler") {
# CPU architecture. We may or may not be doing a cross compile now, so for
# simplicity we always explicitly set the architecture.
if (cpu_arch == "x64") {
- cflags += [ "-m64" ]
+ cflags += [ "-m64", "-march=x86-64", ]
ldflags += [ "-m64" ]
} else if (cpu_arch == "x86") {
cflags += [ "-m32" ]
@@ -704,13 +712,10 @@ config("default_warnings") {
# which we no longer use. Check if it makes sense to remove
# this as well. http://crbug.com/316352
"-Wno-unneeded-internal-declaration",
- ]
- if (!is_mac && !is_ios) {
- cflags_cc += [
- "-Wno-reserved-user-defined-literal",
- ]
- }
+ # TODO(thakis): Remove, http://crbug.com/263960
+ "-Wno-reserved-user-defined-literal",
+ ]
}
if (gcc_version >= 48) {
cflags_cc += [
« no previous file with comments | « build/config/BUILDCONFIG.gn ('k') | tools/gn/bin/gyp_flag_compare.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698