Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 562243004: Revert of Change PageTest.WillStartBrowser to depend on platform instead of browser object as it would not ha… (Closed)

Created:
6 years, 3 months ago by dsinclair
Modified:
6 years, 3 months ago
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Change PageTest.WillStartBrowser to depend on platform instead of browser object as it would not ha… (patchset #1 id:1 of https://codereview.chromium.org/554583003/) Reason for revert: It looks like the moto E perf bots are broken. This change looks like it makes sense so I'm reverting. crbug.com/414267 Original issue's description: > Change PageTest.WillStartBrowser to depend on platform instead of browser object as it would not have been created at this point. > > BUG=413481 > > Committed: https://crrev.com/9bb65868ce3ac1e5aae3a844beacf62281c332b6 > Cr-Commit-Position: refs/heads/master@{#294703} TBR=nduca@chromium.org,nednguyen@google.com,tonyg@chromium.org,chrishenry@google.com,wuhu@google.com NOTREECHECKS=true NOTRY=true BUG=413481 Committed: https://crrev.com/5f712b7be45145522f183d683f11bfb243dd89e1 Cr-Commit-Position: refs/heads/master@{#294816}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -49 lines) Patch
M tools/perf/benchmarks/dromaeo.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/perf/benchmarks/indexeddb_perf.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/perf/benchmarks/kraken.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/perf/benchmarks/octane.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/perf/benchmarks/robohornet_pro.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/perf/benchmarks/sunspider.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/perf/measurements/image_decoding.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/perf/measurements/media.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/perf/measurements/memory.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/perf/measurements/page_cycler.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/perf/measurements/page_cycler_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/measurements/smoothness.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/perf/measurements/smoothness_unittest.py View 2 chunks +3 lines, -3 lines 0 comments Download
M tools/perf/measurements/tab_switching.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/perf/measurements/webrtc.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/perf/metrics/power.py View 4 chunks +12 lines, -14 lines 0 comments Download
M tools/telemetry/telemetry/page/page_runner.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/page/page_runner_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/page/page_test.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/page/record_wpr_unittest.py View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
dsinclair
Created Revert of Change PageTest.WillStartBrowser to depend on platform instead of browser object as it ...
6 years, 3 months ago (2014-09-15 13:52:27 UTC) #1
dsinclair
6 years, 3 months ago (2014-09-15 17:54:49 UTC) #2
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/569333002/ by dsinclair@chromium.org.

The reason for reverting is: Reverting the revert. Bot still failed with this CL
reverted. Sorry for the noise..

Powered by Google App Engine
This is Rietveld 408576698