tools/telemetry/telemetry/page/page_runner_unittest.py - Issue 562243004: Revert of Change PageTest.WillStartBrowser to depend on platform instead of browser object as it would not ha…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/page_runner_unittest.py

Issue 562243004: Revert of Change PageTest.WillStartBrowser to depend on platform instead of browser object as it would not ha… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/page/page_runner_unittest.py

diff --git a/tools/telemetry/telemetry/page/page_runner_unittest.py b/tools/telemetry/telemetry/page/page_runner_unittest.py

index 1f1947a9b19ad1313e6e73ca6fc173d6ce14a83a..bf26ccca19e731383908ca1264bf4f6eb3affd43 100644

--- a/tools/telemetry/telemetry/page/page_runner_unittest.py

+++ b/tools/telemetry/telemetry/page/page_runner_unittest.py

@@ -406,7 +406,7 @@

self._did_call_will_start = False

self._did_call_did_start = False

- def WillStartBrowser(self, platform):

+ def WillStartBrowser(self, browser):

self._did_call_will_start = True

# TODO(simonjam): Test that the profile is available.

« no previous file with comments | « tools/telemetry/telemetry/page/page_runner.py ('k') | tools/telemetry/telemetry/page/page_test.py » ('j') | no next file with comments »