Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Unified Diff: tools/telemetry/telemetry/page/record_wpr_unittest.py

Issue 562243004: Revert of Change PageTest.WillStartBrowser to depend on platform instead of browser object as it would not ha… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/telemetry/page/page_test.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/page/record_wpr_unittest.py
diff --git a/tools/telemetry/telemetry/page/record_wpr_unittest.py b/tools/telemetry/telemetry/page/record_wpr_unittest.py
index 75e79b2adaa6ccf4d086cf9511ea6a41e9293bb6..a434fa9622837dd38f4f3f3a1743a36327237598 100644
--- a/tools/telemetry/telemetry/page/record_wpr_unittest.py
+++ b/tools/telemetry/telemetry/page/record_wpr_unittest.py
@@ -68,7 +68,7 @@
def ValidatePage(self, page, tab, results):
self.func_calls.append('ValidatePage')
- def WillStartBrowser(self, platform):
+ def WillStartBrowser(self, browser):
self.func_calls.append('WillStartBrowser')
def DidStartBrowser(self, browser):
@@ -201,7 +201,7 @@
def testRecorderPageTest_BrowserMethods(self):
record_page_test = record_wpr.RecorderPageTest([])
record_page_test.page_test = MockBenchmark().test()
- record_page_test.WillStartBrowser(self._tab.browser.platform)
+ record_page_test.WillStartBrowser(self._tab.browser)
record_page_test.DidStartBrowser(self._tab.browser)
self.assertTrue('WillStartBrowser' in record_page_test.page_test.func_calls)
self.assertTrue('DidStartBrowser' in record_page_test.page_test.func_calls)
« no previous file with comments | « tools/telemetry/telemetry/page/page_test.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698