Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Issue 561833006: [Mac] Shut down connections to WindowServer before engaging the sandbox. (Closed)

Created:
6 years, 3 months ago by Robert Sesek
Modified:
6 years, 3 months ago
Reviewers:
jeremy
CC:
chromium-reviews, darin-cc_chromium.org, jam, Avi (use Gerrit)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Mac] Shut down connections to WindowServer before engaging the sandbox. The connection is only needed during sandbox warmup to initialize the default color space. It was formerly needed by scrollbar NSAnimations, but that was replaced via https://codereview.chromium.org/529103002/. A similar CL was landed and reverted: https://chromium.googlesource.com/chromium/src.git/+/53ffdf90f4646dbde8df72007fbdc97f3f0220de BUG=397642, 306348 TEST=Manually tested on 10.6-10.10. Committed: https://crrev.com/f3198fb3fc64878b8feb88cfae28ddb7e8bd71ec Cr-Commit-Position: refs/heads/master@{#294382}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -2 lines) Patch
M content/common/sandbox_mac.mm View 3 chunks +15 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Robert Sesek
jeremy: Please review. avi: FYI. I think this a better location for this code anyways.
6 years, 3 months ago (2014-09-10 22:06:46 UTC) #3
Avi (use Gerrit)
SLGTM
6 years, 3 months ago (2014-09-10 22:12:53 UTC) #4
jeremy
LGTM
6 years, 3 months ago (2014-09-11 07:10:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/561833006/20001
6 years, 3 months ago (2014-09-11 12:57:24 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:20001) as 0317cb886d22b3798d16b4526111d09ac7c194fe
6 years, 3 months ago (2014-09-11 13:57:40 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f3198fb3fc64878b8feb88cfae28ddb7e8bd71ec Cr-Commit-Position: refs/heads/master@{#294382}
6 years, 3 months ago (2014-09-11 14:00:25 UTC) #9
Robert Sesek
A revert of this CL (patchset #1 id:20001) has been created in https://codereview.chromium.org/567693002/ by rsesek@chromium.org. ...
6 years, 3 months ago (2014-09-11 17:28:46 UTC) #10
jianli
6 years, 3 months ago (2014-09-11 18:13:22 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:20001) has been created in
https://codereview.chromium.org/561033003/ by jianli@chromium.org.

The reason for reverting is: Your patch might break quite a number of webkit
tests:
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.8%20%28re...
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.7/builds/....

Powered by Google App Engine
This is Rietveld 408576698