Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 561033003: Revert of [Mac] Shut down connections to WindowServer before engaging the sandbox. (Closed)

Created:
6 years, 3 months ago by jianli
Modified:
6 years, 3 months ago
Reviewers:
Robert Sesek, jeremy
CC:
chromium-reviews, darin-cc_chromium.org, jam, Avi (use Gerrit)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of [Mac] Shut down connections to WindowServer before engaging the sandbox. (patchset #1 id:20001 of https://codereview.chromium.org/561833006/) Reason for revert: Your patch might break quite a number of webkit tests: http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.8%20%28retina%29/builds/19050 http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.7/builds/31462 Original issue's description: > [Mac] Shut down connections to WindowServer before engaging the sandbox. > > The connection is only needed during sandbox warmup to initialize the default > color space. It was formerly needed by scrollbar NSAnimations, but that was > replaced via https://codereview.chromium.org/529103002/. > > A similar CL was landed and reverted: > https://chromium.googlesource.com/chromium/src.git/+/53ffdf90f4646dbde8df72007fbdc97f3f0220de > > BUG=397642, 306348 > TEST=Manually tested on 10.6-10.10. > > Committed: https://crrev.com/f3198fb3fc64878b8feb88cfae28ddb7e8bd71ec > Cr-Commit-Position: refs/heads/master@{#294382} TBR=jeremy@chromium.org,rsesek@chromium.org NOTREECHECKS=true NOTRY=true BUG=397642, 306348

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -15 lines) Patch
M content/common/sandbox_mac.mm View 3 chunks +2 lines, -15 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
jianli
Created Revert of [Mac] Shut down connections to WindowServer before engaging the sandbox.
6 years, 3 months ago (2014-09-11 18:13:23 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/561033003/1
6 years, 3 months ago (2014-09-11 18:19:52 UTC) #2
Robert Sesek
On 2014/09/11 18:19:52, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
6 years, 3 months ago (2014-09-11 18:20:16 UTC) #4
Robert Sesek
6 years, 3 months ago (2014-09-11 18:20:26 UTC) #5
not lgtm

Powered by Google App Engine
This is Rietveld 408576698