Fix symbol table handling in functions.

Fix symbol table handling in functions.

Also fixes minor issues with branches in instructions (i.e. defining
entry node and computing predecessors).

BUG= https://code.google.com/p/nativeclient/issues/detail?id=3892
R=stichnot@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=c132b76

[Karl, 2014-09-10 17:14:29]

kschimpf@google.com changed reviewers:
+ jvoung@chromium.org, stichnot@chromium.org

[Jim Stichnoth, 2014-09-10 18:44:24]

https://codereview.chromium.org/561823002/diff/20001/src/IceCfgNode.cpp
File src/IceCfgNode.cpp (right):

https://codereview.chromium.org/561823002/diff/20001/src/IceCfgNode.cpp#newco...
src/IceCfgNode.cpp:38: assert(Name.empty());
Document that the assert is to be sure true renamings aren't happening.

https://codereview.chromium.org/561823002/diff/20001/src/IceCfgNode.h
File src/IceCfgNode.h (right):

https://codereview.chromium.org/561823002/diff/20001/src/IceCfgNode.h#newcode32
src/IceCfgNode.h:32: void setName(IceString &NewName);
Consider putting the whole method definition here, since it's so simple?

getName() is not so simple since it has to synthesize a valid name if one wasn't
given.

https://codereview.chromium.org/561823002/diff/20001/src/IceOperand.cpp
File src/IceOperand.cpp (right):

https://codereview.chromium.org/561823002/diff/20001/src/IceOperand.cpp#newco...
src/IceOperand.cpp:192: assert(Name.empty());
Document that the assert is to be sure true renamings aren't happening.

https://codereview.chromium.org/561823002/diff/20001/src/IceOperand.h
File src/IceOperand.h (right):

https://codereview.chromium.org/561823002/diff/20001/src/IceOperand.h#newcode338
src/IceOperand.h:338: void setName(IceString &NewName);
Also consider putting the whole definition here?

[Karl, 2014-09-10 21:14:33]

https://codereview.chromium.org/561823002/diff/20001/src/IceCfgNode.cpp
File src/IceCfgNode.cpp (right):

https://codereview.chromium.org/561823002/diff/20001/src/IceCfgNode.cpp#newco...
src/IceCfgNode.cpp:38: assert(Name.empty());
On 2014/09/10 18:44:23, stichnot wrote:
> Document that the assert is to be sure true renamings aren't happening.

Done.

https://codereview.chromium.org/561823002/diff/20001/src/IceCfgNode.h
File src/IceCfgNode.h (right):

https://codereview.chromium.org/561823002/diff/20001/src/IceCfgNode.h#newcode32
src/IceCfgNode.h:32: void setName(IceString &NewName);
On 2014/09/10 18:44:23, stichnot wrote:
> Consider putting the whole method definition here, since it's so simple?
> 
> getName() is not so simple since it has to synthesize a valid name if one
wasn't
> given.

Done.

https://codereview.chromium.org/561823002/diff/20001/src/IceOperand.cpp
File src/IceOperand.cpp (right):

https://codereview.chromium.org/561823002/diff/20001/src/IceOperand.cpp#newco...
src/IceOperand.cpp:192: assert(Name.empty());
On 2014/09/10 18:44:23, stichnot wrote:
> Document that the assert is to be sure true renamings aren't happening.

Done.

https://codereview.chromium.org/561823002/diff/20001/src/IceOperand.h
File src/IceOperand.h (right):

https://codereview.chromium.org/561823002/diff/20001/src/IceOperand.h#newcode338
src/IceOperand.h:338: void setName(IceString &NewName);
On 2014/09/10 18:44:23, stichnot wrote:
> Also consider putting the whole definition here?

Done.

[Jim Stichnoth, 2014-09-10 21:37:56]

lgtm

[Karl, 2014-09-11 16:43:55]

Committed patchset #3 (id:40001) manually as c132b76 (tree was closed).