Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 56143002: Make FaviconService() use Porfile as parameter (Closed)

Created:
7 years, 1 month ago by michaelbai
Modified:
7 years, 1 month ago
Reviewers:
sky, Cait (Slow)
CC:
chromium-reviews, tim+watch_chromium.org, extensions-reviews_chromium.org, tfarina, dbeam+watch-ntp_chromium.org, haitaol+watch_chromium.org, browser-components-watch_chromium.org, estade+watch_chromium.org, chromium-apps-reviews_chromium.org, rsimha+watch_chromium.org, pedrosimonetti+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Make FaviconService() use Profile as parameter BUG=308153 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232939

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 4

Patch Set 5 : remove scope_ptr #

Total comments: 1

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : sync #

Total comments: 1

Patch Set 9 : fix unit test but break the DEPS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -45 lines) Patch
M chrome/browser/android/favicon_helper.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/android/provider/chrome_browser_provider.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_html_writer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_model.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/favicon/favicon_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/favicon/favicon_handler_unittest.cc View 1 2 3 4 5 6 7 8 3 chunks +11 lines, -1 line 0 comments Download
M chrome/browser/favicon/favicon_service.h View 1 2 3 4 2 chunks +4 lines, -6 lines 0 comments Download
M chrome/browser/favicon/favicon_service.cc View 1 2 3 4 5 6 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/favicon/favicon_service_factory.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/history/android/sqlite_cursor_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/jumplist_win.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/notifications/message_center_settings_controller.cc View 1 2 3 4 5 6 7 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/favicon_cache.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/android/navigation_popup.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/history_menu_bridge.mm View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/toolbar/back_forward_menu_model.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/webui/extensions/extension_icon_source.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/favicon_source.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/ntp/android/bookmarks_handler.cc View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/ntp/app_launcher_handler.cc View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/webui/ntp/favicon_webui_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/base/testing_profile.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
michaelbai
7 years, 1 month ago (2013-11-01 16:31:01 UTC) #1
sky
Thanks for coming back to this! https://codereview.chromium.org/56143002/diff/90001/chrome/browser/favicon/favicon_service.cc File chrome/browser/favicon/favicon_service.cc (right): https://codereview.chromium.org/56143002/diff/90001/chrome/browser/favicon/favicon_service.cc#newcode68 chrome/browser/favicon/favicon_service.cc:68: history_service_.reset( Isn't the ...
7 years, 1 month ago (2013-11-01 20:06:07 UTC) #2
michaelbai
https://codereview.chromium.org/56143002/diff/90001/chrome/browser/favicon/favicon_service.cc File chrome/browser/favicon/favicon_service.cc (right): https://codereview.chromium.org/56143002/diff/90001/chrome/browser/favicon/favicon_service.cc#newcode68 chrome/browser/favicon/favicon_service.cc:68: history_service_.reset( Yes, the HistoryServiceFactory is the subclass of BrowserContextKeyedServiceFactory. ...
7 years, 1 month ago (2013-11-01 20:22:13 UTC) #3
sky
https://codereview.chromium.org/56143002/diff/90001/chrome/browser/favicon/favicon_service.cc File chrome/browser/favicon/favicon_service.cc (right): https://codereview.chromium.org/56143002/diff/90001/chrome/browser/favicon/favicon_service.cc#newcode68 chrome/browser/favicon/favicon_service.cc:68: history_service_.reset( On 2013/11/01 20:22:13, michaelbai wrote: > Yes, the ...
7 years, 1 month ago (2013-11-01 20:29:24 UTC) #4
michaelbai
Thanks a lot, PTAL https://codereview.chromium.org/56143002/diff/90001/chrome/browser/favicon/favicon_service.cc File chrome/browser/favicon/favicon_service.cc (right): https://codereview.chromium.org/56143002/diff/90001/chrome/browser/favicon/favicon_service.cc#newcode68 chrome/browser/favicon/favicon_service.cc:68: history_service_.reset( On 2013/11/01 20:29:25, sky ...
7 years, 1 month ago (2013-11-01 20:59:01 UTC) #5
sky
LGTM https://codereview.chromium.org/56143002/diff/170001/chrome/browser/favicon/favicon_service.cc File chrome/browser/favicon/favicon_service.cc (right): https://codereview.chromium.org/56143002/diff/170001/chrome/browser/favicon/favicon_service.cc#newcode68 chrome/browser/favicon/favicon_service.cc:68: history_service_ = HistoryServiceFactory::GetForProfile( Move this to member initializer.
7 years, 1 month ago (2013-11-01 21:54:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/michaelbai@chromium.org/56143002/260001
7 years, 1 month ago (2013-11-01 22:58:00 UTC) #7
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 1 month ago (2013-11-01 23:59:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/michaelbai@chromium.org/56143002/450001
7 years, 1 month ago (2013-11-02 01:33:21 UTC) #9
tfarina
https://codereview.chromium.org/56143002/diff/450001/chrome/browser/bookmarks/bookmark_html_writer.cc File chrome/browser/bookmarks/bookmark_html_writer.cc (right): https://codereview.chromium.org/56143002/diff/450001/chrome/browser/bookmarks/bookmark_html_writer.cc#newcode466 chrome/browser/bookmarks/bookmark_html_writer.cc:466: GURL(url), chrome::FAVICON, gfx::kFaviconSize), one less |profile_| usage! that is ...
7 years, 1 month ago (2013-11-02 02:36:54 UTC) #10
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=171046
7 years, 1 month ago (2013-11-02 02:43:45 UTC) #11
michaelbai
Cait seems work on removing the favicon's dependence on history, refer to (favicon's DEPS file), ...
7 years, 1 month ago (2013-11-04 19:23:11 UTC) #12
michaelbai
Chatted with Cait offline, this temporarily allowed #include is fine.
7 years, 1 month ago (2013-11-04 20:04:09 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/michaelbai@chromium.org/56143002/690001
7 years, 1 month ago (2013-11-04 20:13:07 UTC) #14
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 1 month ago (2013-11-04 20:51:27 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/michaelbai@chromium.org/56143002/690001
7 years, 1 month ago (2013-11-04 22:12:15 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/michaelbai@chromium.org/56143002/690001
7 years, 1 month ago (2013-11-05 03:19:42 UTC) #17
commit-bot: I haz the power
7 years, 1 month ago (2013-11-05 07:12:02 UTC) #18
Message was sent while issue was closed. 
Change committed as 232939

Powered by Google App Engine
This is Rietveld 408576698