chrome/browser/ui/webui/extensions/extension_icon_source.cc - Issue 56143002: Make FaviconService() use Porfile as parameter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/extensions/extension_icon_source.cc

Issue 56143002: Make FaviconService() use Porfile as parameter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix unit test but break the DEPS Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/extensions/extension_icon_source.cc

diff --git a/chrome/browser/ui/webui/extensions/extension_icon_source.cc b/chrome/browser/ui/webui/extensions/extension_icon_source.cc

index 22dcf451fe4ee374f1deac33142481526fa83d0f..591edac2cc36a3c5f58c418253459c6b12d0c59f 100644

--- a/chrome/browser/ui/webui/extensions/extension_icon_source.cc

+++ b/chrome/browser/ui/webui/extensions/extension_icon_source.cc

@@ -220,8 +220,8 @@ void ExtensionIconSource::LoadFaviconImage(int request_id) {

GURL favicon_url =

AppLaunchInfo::GetFullLaunchURL(GetData(request_id)->extension);

favicon_service->GetRawFaviconForURL(

- FaviconService::FaviconForURLParams(

- profile_, favicon_url, chrome::FAVICON, gfx::kFaviconSize),

+ FaviconService::FaviconForURLParams(favicon_url, chrome::FAVICON,

+ gfx::kFaviconSize),

ui::SCALE_FACTOR_100P,

base::Bind(&ExtensionIconSource::OnFaviconDataAvailable,

base::Unretained(this), request_id),