chrome/browser/android/favicon_helper.cc - Issue 56143002: Make FaviconService() use Porfile as parameter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/favicon_helper.cc

Issue 56143002: Make FaviconService() use Porfile as parameter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix unit test but break the DEPS Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/android/favicon_helper.cc

diff --git a/chrome/browser/android/favicon_helper.cc b/chrome/browser/android/favicon_helper.cc

index 3694b362f3f88122de32d6d5c5873e8c54b91c88..17a46606003ccb08b53033271f9f9951063fb1e5 100644

--- a/chrome/browser/android/favicon_helper.cc

+++ b/chrome/browser/android/favicon_helper.cc

@@ -90,7 +90,6 @@ jboolean FaviconHelper::GetLocalFaviconImageForURL(

return false;

FaviconService::FaviconForURLParams params(

- profile,

GURL(ConvertJavaStringToUTF16(env, j_page_url)),

static_cast<int>(j_icon_types),

static_cast<int>(j_desired_size_in_dip));

« no previous file with comments | « no previous file | chrome/browser/android/provider/chrome_browser_provider.cc » ('j') | no next file with comments »