Web SQL: Remove unnecessary abstraction.

Web SQL: Remove unnecessary abstraction.

This CL merges
 - AbstractSQLStatement into SQLStatement
 - AbstractSQLStatementBackend into SQLStatementBackend
 - AbstractSQLTransaction into SQLTransaction
 - AbstractSQLTransactionBackend into SQLTransactionBackend
 - DatabaseBase into Database.

'Sync' versions of their subclasses were removed. These abstract classes are
unnecessary.

BUG=397429
TEST=none; No behavior changes.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181809

[tkent, 2014-09-11 08:55:20]

tkent@chromium.org changed reviewers:
+ michaeln@chromium.org, oilpan-reviews@chromium.org

[tkent, 2014-09-11 08:55:21]

Please review this.

[haraken, 2014-09-11 09:22:58]

haraken@chromium.org changed reviewers:
+ haraken@chromium.org

[haraken, 2014-09-11 09:22:59]

LGTM

https://codereview.chromium.org/561143002/diff/1/Source/modules/webdatabase/D...
File Source/modules/webdatabase/Database.cpp (right):

https://codereview.chromium.org/561143002/diff/1/Source/modules/webdatabase/D...
Source/modules/webdatabase/Database.cpp:77:
ASSERT(databaseContext->isContextThread());

Not related to your CL, it's a bit confusing that m_databaseContext belongs to a
database thread but databaseContext belongs to a context thread.

https://codereview.chromium.org/561143002/diff/1/Source/modules/webdatabase/S...
File Source/modules/webdatabase/SQLStatement.h (right):

https://codereview.chromium.org/561143002/diff/1/Source/modules/webdatabase/S...
Source/modules/webdatabase/SQLStatement.h:46: class SQLStatement FINAL : public
NoBaseWillBeGarbageCollectedFinalized<SQLStatement> {

Do we need "Finalized" ?

[tkent, 2014-09-11 09:39:17]

https://codereview.chromium.org/561143002/diff/1/Source/modules/webdatabase/D...
File Source/modules/webdatabase/Database.cpp (right):

https://codereview.chromium.org/561143002/diff/1/Source/modules/webdatabase/D...
Source/modules/webdatabase/Database.cpp:77:
ASSERT(databaseContext->isContextThread());
On 2014/09/11 09:22:59, haraken wrote:
> 
> Not related to your CL, it's a bit confusing that m_databaseContext belongs to
a
> database thread but databaseContext belongs to a context thread.

You misunderstand the first ASSERT, which means m_databaseContext has a thread
object.

https://codereview.chromium.org/561143002/diff/1/Source/modules/webdatabase/S...
File Source/modules/webdatabase/SQLStatement.h (right):

https://codereview.chromium.org/561143002/diff/1/Source/modules/webdatabase/S...
Source/modules/webdatabase/SQLStatement.h:46: class SQLStatement FINAL : public
NoBaseWillBeGarbageCollectedFinalized<SQLStatement> {
On 2014/09/11 09:22:59, haraken wrote:
> 
> Do we need "Finalized" ?

I don't think so.  Will address it in another CL.

[tkent, 2014-09-11 09:39:58]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2014-09-11 09:40:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/561143002/1

[commit-bot: I haz the power, 2014-09-11 10:21:38]

Committed patchset #1 (id:1) as 181809