Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2213)

Unified Diff: Source/modules/webdatabase/SQLStatement.h

Issue 561143002: Web SQL: Remove unnecessary abstraction. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/webdatabase/SQLStatement.h
diff --git a/Source/modules/webdatabase/SQLStatement.h b/Source/modules/webdatabase/SQLStatement.h
index 9b9e7f75a387cea83071a690964dfbfe31336b88..9b878df276310d427210f61d7792f15356bea56f 100644
--- a/Source/modules/webdatabase/SQLStatement.h
+++ b/Source/modules/webdatabase/SQLStatement.h
@@ -29,7 +29,6 @@
#define SQLStatement_h
#include "modules/webdatabase/sqlite/SQLValue.h"
-#include "modules/webdatabase/AbstractSQLStatement.h"
#include "modules/webdatabase/SQLCallbackWrapper.h"
#include "modules/webdatabase/SQLResultSet.h"
#include "wtf/Forward.h"
@@ -37,33 +36,34 @@
namespace blink {
-class AbstractSQLStatementBackend;
class Database;
class SQLError;
+class SQLStatementBackend;
class SQLStatementCallback;
class SQLStatementErrorCallback;
class SQLTransaction;
-class SQLStatement FINAL : public AbstractSQLStatement {
+class SQLStatement FINAL : public NoBaseWillBeGarbageCollectedFinalized<SQLStatement> {
haraken 2014/09/11 09:22:59 Do we need "Finalized" ?
tkent 2014/09/11 09:39:16 I don't think so. Will address it in another CL.
public:
static PassOwnPtrWillBeRawPtr<SQLStatement> create(Database*,
PassOwnPtrWillBeRawPtr<SQLStatementCallback>, PassOwnPtrWillBeRawPtr<SQLStatementErrorCallback>);
- virtual void trace(Visitor*) OVERRIDE;
+ ~SQLStatement();
+ void trace(Visitor*);
bool performCallback(SQLTransaction*);
- virtual void setBackend(AbstractSQLStatementBackend*) OVERRIDE;
+ void setBackend(SQLStatementBackend*);
- virtual bool hasCallback() OVERRIDE;
- virtual bool hasErrorCallback() OVERRIDE;
+ bool hasCallback();
+ bool hasErrorCallback();
private:
SQLStatement(Database*, PassOwnPtrWillBeRawPtr<SQLStatementCallback>, PassOwnPtrWillBeRawPtr<SQLStatementErrorCallback>);
- // The AbstractSQLStatementBackend owns the SQLStatement. Hence, the backend is
+ // The SQLStatementBackend owns the SQLStatement. Hence, the backend is
// guaranteed to be outlive the SQLStatement, and it is safe for us to refer
// to the backend using a raw pointer here.
- RawPtrWillBeMember<AbstractSQLStatementBackend> m_backend;
+ RawPtrWillBeMember<SQLStatementBackend> m_backend;
SQLCallbackWrapper<SQLStatementCallback> m_statementCallbackWrapper;
SQLCallbackWrapper<SQLStatementErrorCallback> m_statementErrorCallbackWrapper;

Powered by Google App Engine
This is Rietveld 408576698