Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Unified Diff: Source/modules/webdatabase/SQLStatementBackend.h

Issue 561143002: Web SQL: Remove unnecessary abstraction. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/webdatabase/SQLStatementBackend.h
diff --git a/Source/modules/webdatabase/SQLStatementBackend.h b/Source/modules/webdatabase/SQLStatementBackend.h
index 816fe53b5d867ec426ae6bc4b894e7864ea71b5f..98dc1aa6a40fc81866b46250e2f57eee7b379562 100644
--- a/Source/modules/webdatabase/SQLStatementBackend.h
+++ b/Source/modules/webdatabase/SQLStatementBackend.h
@@ -29,7 +29,7 @@
#define SQLStatementBackend_h
#include "modules/webdatabase/sqlite/SQLValue.h"
-#include "modules/webdatabase/AbstractSQLStatementBackend.h"
+#include "platform/heap/Handle.h"
#include "wtf/Forward.h"
#include "wtf/PassOwnPtr.h"
#include "wtf/Vector.h"
@@ -37,16 +37,17 @@
namespace blink {
-class AbstractSQLStatement;
class DatabaseBackend;
class SQLErrorData;
+class SQLResultSet;
+class SQLStatement;
class SQLTransactionBackend;
-class SQLStatementBackend FINAL : public AbstractSQLStatementBackend {
+class SQLStatementBackend FINAL : public ThreadSafeRefCountedWillBeGarbageCollectedFinalized<SQLStatementBackend> {
public:
- static PassRefPtrWillBeRawPtr<SQLStatementBackend> create(PassOwnPtrWillBeRawPtr<AbstractSQLStatement>,
+ static PassRefPtrWillBeRawPtr<SQLStatementBackend> create(PassOwnPtrWillBeRawPtr<SQLStatement>,
const String& sqlStatement, const Vector<SQLValue>& arguments, int permissions);
- virtual void trace(Visitor*) OVERRIDE;
+ void trace(Visitor*);
bool execute(DatabaseBackend*);
bool lastExecutionFailedDueToQuota() const;
@@ -56,18 +57,18 @@ public:
void setVersionMismatchedError(DatabaseBackend*);
- AbstractSQLStatement* frontend();
- virtual SQLErrorData* sqlError() const OVERRIDE;
- virtual SQLResultSet* sqlResultSet() const OVERRIDE;
+ SQLStatement* frontend();
+ SQLErrorData* sqlError() const;
+ SQLResultSet* sqlResultSet() const;
private:
- SQLStatementBackend(PassOwnPtrWillBeRawPtr<AbstractSQLStatement>, const String& statement,
+ SQLStatementBackend(PassOwnPtrWillBeRawPtr<SQLStatement>, const String& statement,
const Vector<SQLValue>& arguments, int permissions);
void setFailureDueToQuota(DatabaseBackend*);
void clearFailureDueToQuota();
- OwnPtrWillBeMember<AbstractSQLStatement> m_frontend;
+ OwnPtrWillBeMember<SQLStatement> m_frontend;
String m_statement;
Vector<SQLValue> m_arguments;
bool m_hasCallback;

Powered by Google App Engine
This is Rietveld 408576698