[SyncFS] Expand simple functions to their caller in drive_backend/

[SyncFS] Expand simple functions to their caller in drive_backend/

These functions used to be called asynchronously, and recently switched to be synchronous.
Then it's more readable to expand them to their caller.

BUG=412367
Committed: https://crrev.com/34bdc6daf11a37864798ce691985212d5b46dd12
Cr-Commit-Position: refs/heads/master@{#294140}

[tzik, 2014-09-10 01:38:06]

tzik@chromium.org changed reviewers:
+ peria@chromium.org

[tzik, 2014-09-10 01:38:16]

PTL

https://codereview.chromium.org/560703002/diff/1/chrome/browser/sync_file_sys...
File chrome/browser/sync_file_system/drive_backend/remote_to_local_syncer.cc
(left):

https://codereview.chromium.org/560703002/diff/1/chrome/browser/sync_file_sys...
chrome/browser/sync_file_system/drive_backend/remote_to_local_syncer.cc:632: //
TODO(tzik): Expand this function.
Note: FinalizeSync is called from other places. So IMO, rather than expanding
this, leaving them as is should make this code more readable.

[peria, 2014-09-10 01:59:01]

https://codereview.chromium.org/560703002/diff/1/chrome/browser/sync_file_sys...
File chrome/browser/sync_file_system/drive_backend/remote_to_local_syncer.cc
(left):

https://codereview.chromium.org/560703002/diff/1/chrome/browser/sync_file_sys...
chrome/browser/sync_file_system/drive_backend/remote_to_local_syncer.cc:632: //
TODO(tzik): Expand this function.
On 2014/09/10 01:38:16, tzik wrote:
> Note: FinalizeSync is called from other places. So IMO, rather than expanding
> this, leaving them as is should make this code more readable.

Acknowledged.

https://codereview.chromium.org/560703002/diff/20001/chrome/browser/sync_file...
File chrome/browser/sync_file_system/drive_backend/list_changes_task.cc (right):

https://codereview.chromium.org/560703002/diff/20001/chrome/browser/sync_file...
chrome/browser/sync_file_system/drive_backend/list_changes_task.cc:126: 
nit: There is an extra line.

https://codereview.chromium.org/560703002/diff/20001/chrome/browser/sync_file...
File chrome/browser/sync_file_system/drive_backend/sync_engine_initializer.cc
(right):

https://codereview.chromium.org/560703002/diff/20001/chrome/browser/sync_file...
chrome/browser/sync_file_system/drive_backend/sync_engine_initializer.cc:99:
DCHECK(metadata_database_);
Local variable |metadata_database| (not a member variable |..._|) should be
checked.

[tzik, 2014-09-10 05:00:22]

https://codereview.chromium.org/560703002/diff/20001/chrome/browser/sync_file...
File chrome/browser/sync_file_system/drive_backend/list_changes_task.cc (right):

https://codereview.chromium.org/560703002/diff/20001/chrome/browser/sync_file...
chrome/browser/sync_file_system/drive_backend/list_changes_task.cc:126: 
On 2014/09/10 01:59:01, peria wrote:
> nit: There is an extra line.

Done.

https://codereview.chromium.org/560703002/diff/20001/chrome/browser/sync_file...
File chrome/browser/sync_file_system/drive_backend/sync_engine_initializer.cc
(right):

https://codereview.chromium.org/560703002/diff/20001/chrome/browser/sync_file...
chrome/browser/sync_file_system/drive_backend/sync_engine_initializer.cc:99:
DCHECK(metadata_database_);
On 2014/09/10 01:59:01, peria wrote:
> Local variable |metadata_database| (not a member variable |..._|) should be
> checked.

Good catch! Done.

[peria, 2014-09-10 05:03:11]

lgtm

thanks!

[tzik, 2014-09-10 05:06:30]

The CQ bit was checked by tzik@chromium.org

[commit-bot: I haz the power, 2014-09-10 05:07:01]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tzik@chromium.org/560703002/60001

[commit-bot: I haz the power, 2014-09-10 05:26:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-10 05:26:01]

Try jobs failed on following builders:
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)

[tzik, 2014-09-10 07:13:30]

The CQ bit was checked by tzik@chromium.org

[commit-bot: I haz the power, 2014-09-10 07:14:33]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tzik@chromium.org/560703002/60001

[commit-bot: I haz the power, 2014-09-10 08:02:42]

Committed patchset #4 (id:60001) as 40bfc8fa5539fb8804d77f53cef5eaf2d19c1e6a

[commit-bot: I haz the power, 2014-09-10 10:55:59]

Patchset 4 (id:??) landed as
https://crrev.com/34bdc6daf11a37864798ce691985212d5b46dd12
Cr-Commit-Position: refs/heads/master@{#294140}