[SyncFS] Expand simple functions to their caller in drive_backend/

chrome/browser/sync_file_system/drive_backend/remote_to_local_syncer.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync_file_system/drive_backend/remote_to_local_syncer.h"
 
 #include "base/bind.h"
 #include "base/callback.h"
 #include "base/files/file_util.h"
 #include "base/format_macros.h"
@@ skipping 310 matching lines @@
     return;
   }
 
   if (!entry) {
     NOTREACHED();
     SyncCompleted(token.Pass(), SYNC_STATUS_FAILED);
     return;
   }
 
   status = metadata_database()->UpdateByFileResource(*entry);
-  // TODO(tzik): Expand this function.
-  DidUpdateDatabaseForRemoteMetadata(token.Pass(), status);
-}
-
-void RemoteToLocalSyncer::DidUpdateDatabaseForRemoteMetadata(
-    scoped_ptr<SyncTaskToken> token,
-    SyncStatusCode status) {
   if (status != SYNC_STATUS_OK) {
     SyncCompleted(token.Pass(), status);
     return;
   }
 
   metadata_database()->PromoteDemotedTracker(dirty_tracker_->tracker_id());
 
   // Do not update |dirty_tracker_|.
   SyncCompleted(token.Pass(), SYNC_STATUS_RETRY);
 }
@@ skipping 274 matching lines @@
       updated_details.set_md5(dirty_tracker_->synced_details().md5());
     if (!dirty_tracker_->active()) {
       // Keep missing true, as the change hasn't been synced to local.
       updated_details.clear_md5();
       updated_details.set_missing(true);
     }
   }
 
   status = metadata_database()->UpdateTracker(
       dirty_tracker_->tracker_id(), updated_details);
-  // TODO(tzik): Expand this function.

[tzik, 2014/09/10 01:38:16]

Note: FinalizeSync is called from other places. So IMO, rather than expanding
this, leaving them as is should make this code more readable.

[peria, 2014/09/10 01:59:01]

Acknowledged.

   FinalizeSync(token.Pass(), status);
 }
 
 void RemoteToLocalSyncer::FinalizeSync(scoped_ptr<SyncTaskToken> token,
                                        SyncStatusCode status) {
   if (prepared_) {
     remote_change_processor()->FinalizeRemoteSync(
         url_, false /* clear_local_change */,
         base::Bind(SyncTaskManager::NotifyTaskDone,
                    base::Passed(&token), status));
@@ skipping 117 matching lines @@
 
 SyncStatusCallback RemoteToLocalSyncer::SyncCompletedCallback(
     scoped_ptr<SyncTaskToken> token) {
   return base::Bind(&RemoteToLocalSyncer::SyncCompleted,
                     weak_ptr_factory_.GetWeakPtr(),
                     base::Passed(&token));
 }
 
 }  // namespace drive_backend
 }  // namespace sync_file_system