chrome/browser/sync_file_system/drive_backend/remote_to_local_syncer.cc - Issue 560703002: [SyncFS] Expand simple functions to their caller in drive_backend/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync_file_system/drive_backend/remote_to_local_syncer.cc

Issue 560703002: [SyncFS] Expand simple functions to their caller in drive_backend/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@03_context_rename

Patch Set: rebase Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync_file_system/drive_backend/remote_to_local_syncer.h ('k') | chrome/browser/sync_file_system/drive_backend/sync_engine_initializer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync_file_system/drive_backend/remote_to_local_syncer.cc

diff --git a/chrome/browser/sync_file_system/drive_backend/remote_to_local_syncer.cc b/chrome/browser/sync_file_system/drive_backend/remote_to_local_syncer.cc

index 74b345ea007c85af026ce3569bb4e3c40d136ca6..003622cea4621b11b04340040a0f284008c57774 100644

--- a/chrome/browser/sync_file_system/drive_backend/remote_to_local_syncer.cc

+++ b/chrome/browser/sync_file_system/drive_backend/remote_to_local_syncer.cc

@@ -328,13 +328,6 @@ void RemoteToLocalSyncer::DidGetRemoteMetadata(

}

status = metadata_database()->UpdateByFileResource(*entry);

- // TODO(tzik): Expand this function.

- DidUpdateDatabaseForRemoteMetadata(token.Pass(), status);

-void RemoteToLocalSyncer::DidUpdateDatabaseForRemoteMetadata(

- scoped_ptr<SyncTaskToken> token,

- SyncStatusCode status) {

if (status != SYNC_STATUS_OK) {

SyncCompleted(token.Pass(), status);

return;

@@ -629,7 +622,6 @@ void RemoteToLocalSyncer::SyncCompleted(scoped_ptr<SyncTaskToken> token,

status = metadata_database()->UpdateTracker(

dirty_tracker_->tracker_id(), updated_details);

- // TODO(tzik): Expand this function.

FinalizeSync(token.Pass(), status);

}