Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 560523004: DevTools: Made id unique across different remote browsers (Closed)

Created:
6 years, 3 months ago by vkuzkokov
Modified:
6 years, 3 months ago
Reviewers:
dgozman, pfeldman
CC:
chromium-reviews, vsevik, yurys, paulirish+reviews_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

DevTools: Made id unique across different remote browsers BUG=338303 Committed: https://crrev.com/564697be98ca9dea6fcfc1a7cfe1dc10cb076c65 Cr-Commit-Position: refs/heads/master@{#296385}

Patch Set 1 #

Patch Set 2 : Test id uniqueness #

Patch Set 3 : Fixed leak in test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -11 lines) Patch
M chrome/browser/devtools/device/adb/adb_client_socket_browsertest.cc View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/devtools/device/adb/mock_adb_server.cc View 1 1 chunk +14 lines, -4 lines 0 comments Download
M chrome/browser/devtools/device/devtools_android_bridge.cc View 4 chunks +8 lines, -6 lines 0 comments Download
M chrome/browser/resources/inspect/inspect.js View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/data/webui/inspect_ui_test.js View 1 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (4 generated)
vkuzkokov
6 years, 3 months ago (2014-09-18 13:14:11 UTC) #2
dgozman
Can we add a test for this?
6 years, 3 months ago (2014-09-18 13:27:09 UTC) #3
vkuzkokov
Added test
6 years, 3 months ago (2014-09-19 15:50:38 UTC) #4
dgozman
lgtm +pfeldman@ for inspect.js
6 years, 3 months ago (2014-09-22 11:50:24 UTC) #6
vkuzkokov
Pavel, PTAL
6 years, 3 months ago (2014-09-23 14:00:07 UTC) #7
pfeldman
lgtm
6 years, 3 months ago (2014-09-23 14:23:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/560523004/20001
6 years, 3 months ago (2014-09-23 14:29:54 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001) as dfd012f4e0b11fc941d8113f41a6162a57262772
6 years, 3 months ago (2014-09-23 15:28:06 UTC) #11
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/7732fd3f76fc31a95f14199f898804e5d80e96e3 Cr-Commit-Position: refs/heads/master@{#296188}
6 years, 3 months ago (2014-09-23 15:28:56 UTC) #12
dewittj
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/598663002/ by dewittj@chromium.org. ...
6 years, 3 months ago (2014-09-23 17:18:55 UTC) #13
vkuzkokov
Fixed and checked. Relanding.
6 years, 3 months ago (2014-09-24 07:11:57 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/560523004/40001
6 years, 3 months ago (2014-09-24 10:15:22 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 0d63ffd902f52a5f8a9bc5e579e6a3d0ddbc5ab7
6 years, 3 months ago (2014-09-24 11:14:17 UTC) #17
commit-bot: I haz the power
6 years, 3 months ago (2014-09-24 11:14:48 UTC) #18
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/564697be98ca9dea6fcfc1a7cfe1dc10cb076c65
Cr-Commit-Position: refs/heads/master@{#296385}

Powered by Google App Engine
This is Rietveld 408576698