Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1701)

Unified Diff: chrome/browser/devtools/device/devtools_android_bridge.cc

Issue 560523004: DevTools: Made id unique across different remote browsers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed leak in test Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/devtools/device/adb/mock_adb_server.cc ('k') | chrome/browser/resources/inspect/inspect.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/devtools/device/devtools_android_bridge.cc
diff --git a/chrome/browser/devtools/device/devtools_android_bridge.cc b/chrome/browser/devtools/device/devtools_android_bridge.cc
index db7f1f5f4262b7ae0dc618db73f88cb8bbafb803..e36e78584504c6c32206830c762f4843fe1bcd91 100644
--- a/chrome/browser/devtools/device/devtools_android_bridge.cc
+++ b/chrome/browser/devtools/device/devtools_android_bridge.cc
@@ -311,10 +311,10 @@ AgentHostDelegate::GetOrCreateAgentHost(
const std::string& id,
scoped_refptr<DevToolsAndroidBridge::RemoteBrowser> browser,
const std::string& debug_url) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
- AgentHostDelegates::iterator it = g_host_delegates.Get().find(id);
- if (it != g_host_delegates.Get().end())
- return it->second->agent_host_;
+ DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+ AgentHostDelegates::iterator it = g_host_delegates.Get().find(id);
+ if (it != g_host_delegates.Get().end())
+ return it->second->agent_host_;
AgentHostDelegate* delegate = new AgentHostDelegate(id, browser, debug_url);
scoped_refptr<content::DevToolsAgentHost> result =
@@ -415,6 +415,7 @@ class RemotePageTarget : public DevToolsTargetImpl,
std::string frontend_url_;
std::string remote_id_;
std::string remote_type_;
+ std::string local_id_;
DISALLOW_COPY_AND_ASSIGN(RemotePageTarget);
};
@@ -451,7 +452,8 @@ RemotePageTarget::RemotePageTarget(
browser_(browser),
debug_url_(GetDebugURL(value)),
remote_id_(GetStringProperty(value, "id")),
- remote_type_(GetStringProperty(value, "type")) {
+ remote_type_(GetStringProperty(value, "type")),
+ local_id_(BuildUniqueTargetId(browser.get(), value)) {
set_type("adb_page");
set_url(GURL(GetStringProperty(value, "url")));
set_title(base::UTF16ToUTF8(net::UnescapeForHTML(base::UTF8ToUTF16(
@@ -480,7 +482,7 @@ std::string RemotePageTarget::GetFrontendURL() {
}
std::string RemotePageTarget::GetId() const {
- return remote_id_;
+ return local_id_;
}
bool RemotePageTarget::IsAttached() const {
« no previous file with comments | « chrome/browser/devtools/device/adb/mock_adb_server.cc ('k') | chrome/browser/resources/inspect/inspect.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698