Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5182)

Unified Diff: chrome/browser/devtools/device/adb/adb_client_socket_browsertest.cc

Issue 560523004: DevTools: Made id unique across different remote browsers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed leak in test Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/devtools/device/adb/mock_adb_server.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/devtools/device/adb/adb_client_socket_browsertest.cc
diff --git a/chrome/browser/devtools/device/adb/adb_client_socket_browsertest.cc b/chrome/browser/devtools/device/adb/adb_client_socket_browsertest.cc
index b6e2ec09901de0838200a1144c521d2ac706b0ef..6d3b125e813ee99348c7d4156e547272ed94e2ba 100644
--- a/chrome/browser/devtools/device/adb/adb_client_socket_browsertest.cc
+++ b/chrome/browser/devtools/device/adb/adb_client_socket_browsertest.cc
@@ -101,11 +101,12 @@ class AdbClientSocketTest : public InProcessBrowserTest,
webview->CreatePages();
ASSERT_EQ(1U, chrome_pages.size());
- ASSERT_EQ(0U, chrome_beta_pages.size());
+ ASSERT_EQ(1U, chrome_beta_pages.size());
ASSERT_EQ(2U, webview_pages.size());
// Check that we have non-empty description for webview pages.
ASSERT_EQ(0U, chrome_pages[0]->GetTarget()->GetDescription().size());
+ ASSERT_EQ(0U, chrome_beta_pages[0]->GetTarget()->GetDescription().size());
ASSERT_NE(0U, webview_pages[0]->GetTarget()->GetDescription().size());
ASSERT_NE(0U, webview_pages[1]->GetTarget()->GetDescription().size());
@@ -115,6 +116,7 @@ class AdbClientSocketTest : public InProcessBrowserTest,
chrome_pages[0]->GetTarget()->GetTitle());
STLDeleteElements(&chrome_pages);
+ STLDeleteElements(&chrome_beta_pages);
STLDeleteElements(&webview_pages);
}
« no previous file with comments | « no previous file | chrome/browser/devtools/device/adb/mock_adb_server.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698