Merge ExecutionContextClient and ExecutionContext

Merge ExecutionContextClient and ExecutionContext

ExecutionContextClient was introduced in https://codereview.chromium.org/27311002. Now it isn't used.

R=vsevik@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181803

[kozyatinskiy1, 2014-09-10 07:04:10]

Patchset #2 (id:20001) has been deleted

[kozyatinskiy1, 2014-09-10 15:47:14]

Vsevolod, please take a look.

[kozyatinskiy1, 2014-09-10 16:00:22]

Patchset #2 (id:40001) has been deleted

[vsevik, 2014-09-10 17:59:40]

vsevik@chromium.org changed reviewers:
+ morrita@chromium.org

[vsevik, 2014-09-10 17:59:41]

morrita@, You have originally done the split of these two. Our understanding is
that this is no longer needed so we merge them back, could you please review
this?

[Hajime Morrita, 2014-09-10 19:43:23]

On 2014/09/10 17:59:41, vsevik wrote:
> morrita@, You have originally done the split of these two. Our understanding
is
> that this is no longer needed so we merge them back, could you please review
> this?

lgtm. Thanks for doing this!

[vsevik, 2014-09-10 21:26:34]

lgtm, thanks.

https://codereview.chromium.org/559553002/diff/60001/Source/core/testing/Null...
File Source/core/testing/NullExecutionContext.cpp (right):

https://codereview.chromium.org/559553002/diff/60001/Source/core/testing/Null...
Source/core/testing/NullExecutionContext.cpp:8: #include
"core/dom/ExecutionContextTask.h"
redundant.

https://codereview.chromium.org/559553002/diff/60001/Source/core/testing/Null...
Source/core/testing/NullExecutionContext.cpp:33: void
NullExecutionContext::postTask(PassOwnPtr<ExecutionContextTask>)
We could inline this one.

[kozyatinskiy1, 2014-09-11 07:27:24]

https://codereview.chromium.org/559553002/diff/60001/Source/core/testing/Null...
File Source/core/testing/NullExecutionContext.cpp (right):

https://codereview.chromium.org/559553002/diff/60001/Source/core/testing/Null...
Source/core/testing/NullExecutionContext.cpp:8: #include
"core/dom/ExecutionContextTask.h"
On 2014/09/10 21:26:34, vsevik wrote:
> redundant.

No, it's not redundant. Here we use PassOwnPtr (not PassRefPtr) in
OwnPtrCommon.h you can find next line: COMPILE_ASSERT(sizeof(T) > 0,
TypeMustBeComplete); in OwnedPtrDeleter::deletePtr function. Type must be
complete.

https://codereview.chromium.org/559553002/diff/60001/Source/core/testing/Null...
Source/core/testing/NullExecutionContext.cpp:33: void
NullExecutionContext::postTask(PassOwnPtr<ExecutionContextTask>)
On 2014/09/10 21:26:34, vsevik wrote:
> We could inline this one.

Because we can't define this function without ExecutionContextTask header, I
suppose that it's not good to make this function inline.

[kozyatinskiy1, 2014-09-11 07:30:59]

The CQ bit was checked by kozyatinskiy@google.com

[commit-bot: I haz the power, 2014-09-11 07:32:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/559553002/80001

[commit-bot: I haz the power, 2014-09-11 08:42:45]

Committed patchset #3 (id:80001) as 181803