Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(609)

Unified Diff: Source/core/dom/ExecutionContext.cpp

Issue 559553002: Merge ExecutionContextClient and ExecutionContext (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@tmp1
Patch Set: Rebased Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/dom/ExecutionContext.h ('k') | Source/core/dom/ExecutionContextClient.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/ExecutionContext.cpp
diff --git a/Source/core/dom/ExecutionContext.cpp b/Source/core/dom/ExecutionContext.cpp
index a5ee223d3e5c561cb393b8962113fd7601cde549..3ebf654b77ec50ceab16530eca43b88d3665a303 100644
--- a/Source/core/dom/ExecutionContext.cpp
+++ b/Source/core/dom/ExecutionContext.cpp
@@ -67,8 +67,7 @@ public:
};
ExecutionContext::ExecutionContext()
- : m_client(0)
- , m_sandboxFlags(SandboxNone)
+ : m_sandboxFlags(SandboxNone)
, m_circularSequentialID(0)
, m_inDispatchErrorEvent(false)
, m_activeDOMObjectsAreSuspended(false)
@@ -111,15 +110,13 @@ unsigned ExecutionContext::activeDOMObjectCount()
void ExecutionContext::suspendScheduledTasks()
{
suspendActiveDOMObjects();
- if (m_client)
- m_client->tasksWereSuspended();
+ tasksWereSuspended();
}
void ExecutionContext::resumeScheduledTasks()
{
resumeActiveDOMObjects();
- if (m_client)
- m_client->tasksWereResumed();
+ tasksWereResumed();
}
void ExecutionContext::suspendActiveDOMObjectIfNeeded(ActiveDOMObject* object)
@@ -146,32 +143,22 @@ void ExecutionContext::reportException(PassRefPtrWillBeRawPtr<ErrorEvent> event,
}
// First report the original exception and only then all the nested ones.
- if (!dispatchErrorEvent(errorEvent, corsStatus) && m_client)
- m_client->logExceptionToConsole(errorEvent->messageForConsole(), scriptId, errorEvent->filename(), errorEvent->lineno(), errorEvent->colno(), callStack);
+ if (!dispatchErrorEvent(errorEvent, corsStatus))
+ logExceptionToConsole(errorEvent->messageForConsole(), scriptId, errorEvent->filename(), errorEvent->lineno(), errorEvent->colno(), callStack);
if (!m_pendingExceptions)
return;
for (size_t i = 0; i < m_pendingExceptions->size(); i++) {
PendingException* e = m_pendingExceptions->at(i).get();
- if (m_client)
- m_client->logExceptionToConsole(e->m_errorMessage, e->m_scriptId, e->m_sourceURL, e->m_lineNumber, e->m_columnNumber, e->m_callStack);
+ logExceptionToConsole(e->m_errorMessage, e->m_scriptId, e->m_sourceURL, e->m_lineNumber, e->m_columnNumber, e->m_callStack);
}
m_pendingExceptions.clear();
}
-void ExecutionContext::addConsoleMessage(PassRefPtrWillBeRawPtr<ConsoleMessage> consoleMessage)
-{
- if (!m_client)
- return;
- m_client->addMessage(consoleMessage);
-}
-
bool ExecutionContext::dispatchErrorEvent(PassRefPtrWillBeRawPtr<ErrorEvent> event, AccessControlStatus corsStatus)
{
- if (!m_client)
- return false;
- EventTarget* target = m_client->errorEventTarget();
+ EventTarget* target = errorEventTarget();
if (!target)
return false;
@@ -231,73 +218,26 @@ void ExecutionContext::didChangeTimerAlignmentInterval()
iter->value->didChangeAlignmentInterval();
}
-SecurityOrigin* ExecutionContext::securityOrigin() const
+SecurityOrigin* ExecutionContext::securityOrigin()
{
- RELEASE_ASSERT(m_client);
- return m_client->securityContext().securityOrigin();
+ return securityContext().securityOrigin();
}
-ContentSecurityPolicy* ExecutionContext::contentSecurityPolicy() const
+ContentSecurityPolicy* ExecutionContext::contentSecurityPolicy()
{
- RELEASE_ASSERT(m_client);
- return m_client->securityContext().contentSecurityPolicy();
+ return securityContext().contentSecurityPolicy();
}
const KURL& ExecutionContext::url() const
{
- if (!m_client) {
- DEFINE_STATIC_LOCAL(KURL, emptyURL, ());
- return emptyURL;
- }
-
return virtualURL();
}
KURL ExecutionContext::completeURL(const String& url) const
{
-
- if (!m_client) {
- DEFINE_STATIC_LOCAL(KURL, emptyURL, ());
- return emptyURL;
- }
-
return virtualCompleteURL(url);
}
-void ExecutionContext::disableEval(const String& errorMessage)
-{
- if (!m_client)
- return;
- return m_client->disableEval(errorMessage);
-}
-
-LocalDOMWindow* ExecutionContext::executingWindow() const
-{
- RELEASE_ASSERT(m_client);
- return m_client->executingWindow();
-}
-
-String ExecutionContext::userAgent(const KURL& url) const
-{
- if (!m_client)
- return String();
- return m_client->userAgent(url);
-}
-
-double ExecutionContext::timerAlignmentInterval() const
-{
- if (!m_client)
- return DOMTimer::visiblePageAlignmentInterval();
- return m_client->timerAlignmentInterval();
-}
-
-void ExecutionContext::postTask(PassOwnPtr<ExecutionContextTask> task)
-{
- if (!m_client)
- return;
- m_client->postTask(task);
-}
-
PassOwnPtr<LifecycleNotifier<ExecutionContext> > ExecutionContext::createLifecycleNotifier()
{
return ContextLifecycleNotifier::create(this);
@@ -317,11 +257,10 @@ void ExecutionContext::enforceSandboxFlags(SandboxFlags mask)
{
m_sandboxFlags |= mask;
- RELEASE_ASSERT(m_client);
// The SandboxOrigin is stored redundantly in the security origin.
- if (isSandboxed(SandboxOrigin) && m_client->securityContext().securityOrigin() && !m_client->securityContext().securityOrigin()->isUnique()) {
- m_client->securityContext().setSecurityOrigin(SecurityOrigin::createUnique());
- m_client->didUpdateSecurityOrigin();
+ if (isSandboxed(SandboxOrigin) && securityContext().securityOrigin() && !securityContext().securityOrigin()->isUnique()) {
+ securityContext().setSecurityOrigin(SecurityOrigin::createUnique());
+ didUpdateSecurityOrigin();
}
}
« no previous file with comments | « Source/core/dom/ExecutionContext.h ('k') | Source/core/dom/ExecutionContextClient.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698