Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 27311002: Introduce ExecutionContextClient (Closed)

Created:
7 years, 2 months ago by Hajime Morrita
Modified:
7 years, 2 months ago
Reviewers:
tkent, haraken
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org
Visibility:
Public.

Description

Introduce ExecutionContextClient This extracts most of the virtual functions from ScriptExecutionContext to newly introduced ExecutionContextClient interface, which Document and WorkerGlobalScope implement. ScriptExecutionContext::suspendActiveDOMObjects(), resumeActiveDOMObjects(), stopActiveDOMObjects() are devirtualized as there are no overrides of them. This is a preparation for decoupling ScriptExecutionContext from Document inheritance chain. This is re-landing r159421 which was reverted at r159599 due to reported crashes. This change now have some NULL checks to prevent such crashes. BUG=305497, 306880 TEST=none R=haraken@chromium.org TBR=abarth@chromium.org, dglazkov@chromium.org, tkent@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159656

Patch Set 1 #

Patch Set 2 : Fix clang build error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+196 lines, -40 lines) Patch
M Source/core/dom/Document.h View 2 chunks +1 line, -2 lines 0 comments Download
M Source/core/dom/Document.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/dom/ExecutionContext.h View 5 chunks +16 lines, -25 lines 0 comments Download
M Source/core/dom/ExecutionContext.cpp View 2 chunks +84 lines, -10 lines 0 comments Download
A Source/core/dom/ExecutionContextClient.h View 1 1 chunk +75 lines, -0 lines 0 comments Download
M Source/core/workers/WorkerGlobalScope.h View 4 chunks +5 lines, -3 lines 0 comments Download
M Source/core/workers/WorkerGlobalScope.cpp View 4 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Hajime Morrita
Rubberstamp please? This is relanding a reverted CL.
7 years, 2 months ago (2013-10-15 08:56:01 UTC) #1
haraken
rubberstamp LGTM.
7 years, 2 months ago (2013-10-15 08:59:09 UTC) #2
Hajime Morrita
7 years, 2 months ago (2013-10-15 09:13:23 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r159656 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698