Stop using an atom to store plugin name/version on Windows.

Stop using an atom to store plugin name/version on Windows.

On the swarming bots we are seeing flakes in the plugin tests. Setting the atom fails because the atom table fills up. I tracked this down to the fact that sometimes the atom destruction path doesn't get hit depending on how the plugin shuts down. Rather than fix it, I removed this code and used a simpler mechanism to get the title & version in the browser process.

BUG=412042
Committed: https://crrev.com/3458fc0095102a5734c0e223f0a15b5a43644021
Cr-Commit-Position: refs/heads/master@{#294088}

[jam, 2014-09-10 00:13:57]

jam@chromium.org changed reviewers:
+ brettw@chromium.org

[brettw, 2014-09-10 00:17:27]

LGTM with types changed.

(definitions of those are in base/process/process_handle.h)

https://codereview.chromium.org/557893003/diff/1/content/browser/plugin_servi...
File content/browser/plugin_service_impl.cc (right):

https://codereview.chromium.org/557893003/diff/1/content/browser/plugin_servi...
content/browser/plugin_service_impl.cc:848: if
(!PluginProcessHost::GetWebPluginInfoFromPluginPid(process_id, &info))
I'm surprised this doesn't give you an error about downconverting from DWORD ->
int.

I would have expected base::ProcessId to be used in the places where you use
int, and base::kNullProcessId to be used where you use -1.

[jam, 2014-09-10 01:15:20]

https://codereview.chromium.org/557893003/diff/1/content/browser/plugin_servi...
File content/browser/plugin_service_impl.cc (right):

https://codereview.chromium.org/557893003/diff/1/content/browser/plugin_servi...
content/browser/plugin_service_impl.cc:848: if
(!PluginProcessHost::GetWebPluginInfoFromPluginPid(process_id, &info))
On 2014/09/10 00:17:27, brettw wrote:
> I'm surprised this doesn't give you an error about downconverting from DWORD
->
> int.
> 
> I would have expected base::ProcessId to be used in the places where you use
> int, and base::kNullProcessId to be used where you use -1.

Done.

[jam, 2014-09-10 01:15:36]

The CQ bit was checked by jam@chromium.org

[jam, 2014-09-10 01:24:07]

The CQ bit was checked by jam@chromium.org

[commit-bot: I haz the power, 2014-09-10 01:27:21]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jam@chromium.org/557893003/20001

[commit-bot: I haz the power, 2014-09-10 03:24:25]

Committed patchset #2 (id:20001) as 139e6e31b0a1b0785773b548e4b11ff2b2142897

[commit-bot: I haz the power, 2014-09-10 03:58:40]

Patchset 2 (id:??) landed as
https://crrev.com/3458fc0095102a5734c0e223f0a15b5a43644021
Cr-Commit-Position: refs/heads/master@{#294088}