Stop using an atom to store plugin name/version on Windows.

content/browser/plugin_service_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/plugin_service_impl.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/compiler_specific.h"
 #include "base/files/file_path.h"
@@ skipping 823 matching lines @@
   return false;
 }
 
 bool PluginServiceImpl::GetPluginInfoFromWindow(
     HWND window,
     base::string16* plugin_name,
     base::string16* plugin_version) {
   if (!IsPluginWindow(window))
     return false;
 
-  GetPluginPropertyFromWindow(
-          window, kPluginNameAtomProperty, plugin_name);
-  GetPluginPropertyFromWindow(
-          window, kPluginVersionAtomProperty, plugin_version);
+
+  DWORD process_id = 0;
+  GetWindowThreadProcessId(window, &process_id);
+  WebPluginInfo info;
+  if (!PluginProcessHost::GetWebPluginInfoFromPluginPid(process_id, &info))

[brettw, 2014/09/10 00:17:27]

I'm surprised this doesn't give you an error about downconverting from DWORD ->
int.

I would have expected base::ProcessId to be used in the places where you use
int, and base::kNullProcessId to be used where you use -1.

[jam, 2014/09/10 01:15:20]

Done.

+    return false;
+
+  *plugin_name = info.name;
+  *plugin_version = info.version;
   return true;
 }
 
 bool PluginServiceImpl::IsPluginWindow(HWND window) {
   return gfx::GetClassName(window) == base::string16(kNativeWindowClassName);
 }
 #endif
 
 bool PluginServiceImpl::PpapiDevChannelSupported(
     BrowserContext* browser_context,
     const GURL& document_url) {
   return content::GetContentClient()->browser()->
       IsPluginAllowedToUseDevChannelAPIs(browser_context, document_url);
 }
 
 }  // namespace content