Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1525)

Unified Diff: content/browser/plugin_service_impl.cc

Issue 557893003: Stop using an atom to store plugin name/version on Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/plugin_process_host.cc ('k') | content/child/npapi/webplugin_delegate_impl_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/plugin_service_impl.cc
diff --git a/content/browser/plugin_service_impl.cc b/content/browser/plugin_service_impl.cc
index e4be1a024b32ffc27afe5fbdfdf55ff69b625235..1b7ad7641c43cbb8d517b76869f17def73732935 100644
--- a/content/browser/plugin_service_impl.cc
+++ b/content/browser/plugin_service_impl.cc
@@ -841,10 +841,15 @@ bool PluginServiceImpl::GetPluginInfoFromWindow(
if (!IsPluginWindow(window))
return false;
- GetPluginPropertyFromWindow(
- window, kPluginNameAtomProperty, plugin_name);
- GetPluginPropertyFromWindow(
- window, kPluginVersionAtomProperty, plugin_version);
+
+ DWORD process_id = 0;
+ GetWindowThreadProcessId(window, &process_id);
+ WebPluginInfo info;
+ if (!PluginProcessHost::GetWebPluginInfoFromPluginPid(process_id, &info))
+ return false;
+
+ *plugin_name = info.name;
+ *plugin_version = info.version;
return true;
}
« no previous file with comments | « content/browser/plugin_process_host.cc ('k') | content/child/npapi/webplugin_delegate_impl_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698