Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(877)

Issue 557753002: Code cleanup for showValidationMessage (Closed)

Created:
6 years, 3 months ago by Habib Virji
Modified:
6 years, 3 months ago
Reviewers:
tkent
CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Code cleanup for showValidationMessage Removing showValidationMessage, as code on the chromium side has landed. R=tkent@chromium.org BUG=91638 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181697

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M Source/web/ValidationMessageClientImpl.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M public/web/WebViewClient.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Habib Virji
Cleanup as code for Validation message, as chromium side changes has landed.
6 years, 3 months ago (2014-09-09 12:19:48 UTC) #1
tkent
lgtm
6 years, 3 months ago (2014-09-09 23:22:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/habib.virji@samsung.com/557753002/1
6 years, 3 months ago (2014-09-09 23:23:20 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/26321)
6 years, 3 months ago (2014-09-10 01:14:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/habib.virji@samsung.com/557753002/1
6 years, 3 months ago (2014-09-10 01:17:49 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:01:02 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 181697

Powered by Google App Engine
This is Rietveld 408576698