public/web/WebViewClient.h - Issue 557753002: Code cleanup for showValidationMessage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: public/web/WebViewClient.h

Issue 557753002: Code cleanup for showValidationMessage (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: public/web/WebViewClient.h

diff --git a/public/web/WebViewClient.h b/public/web/WebViewClient.h

index 172919c8e0f044375d0bb9f6fbff8fcf409926e4..2d37c37a58f43a529b8ad29baf17171f0e12e517 100644

--- a/public/web/WebViewClient.h

+++ b/public/web/WebViewClient.h

@@ -159,8 +159,6 @@ public:

// besides the anchor rectangle. An implementation of this function should

// not hide the popup until hideValidationMessage call.

virtual void showValidationMessage(const WebRect& anchorInRootView, const WebString& mainText, WebTextDirection mainTextDir, const WebString& supplementalText, WebTextDirection supplementalTextDir) { }

- // FIXME: BUG91638, when landed on chrome side, this will be removed.

- virtual void showValidationMessage(const WebRect& anchorInRootView, const WebString& mainText, const WebString& supplementalText, WebTextDirection hint) { }

// Hide notifation popup for form validation messages.

virtual void hideValidationMessage() { }

« no previous file with comments | « Source/web/ValidationMessageClientImpl.cpp ('k') | no next file » | no next file with comments »