Source/web/ValidationMessageClientImpl.cpp - Issue 557753002: Code cleanup for showValidationMessage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/ValidationMessageClientImpl.cpp

Issue 557753002: Code cleanup for showValidationMessage (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/ValidationMessageClientImpl.cpp

diff --git a/Source/web/ValidationMessageClientImpl.cpp b/Source/web/ValidationMessageClientImpl.cpp

index 2f3059cfaf8602fce0be0c39eeb158341b198712..5c3bc88d3d9e101321ac0d36fe405ebcf13354d7 100644

--- a/Source/web/ValidationMessageClientImpl.cpp

+++ b/Source/web/ValidationMessageClientImpl.cpp

@@ -83,7 +83,6 @@ void ValidationMessageClientImpl::showValidationMessage(const Element& anchor, c

m_webView.client()->showValidationMessage(anchorInRootView, m_message, toWebTextDirection(messageDir),

subMessage, toWebTextDirection(subMessageDir));

- m_webView.client()->showValidationMessage(anchorInRootView, m_message, subMessage, toWebTextDirection(messageDir));

m_finishTime = monotonicallyIncreasingTime() + std::max(minimumSecondToShowValidationMessage, (message.length() + subMessage.length()) * secondPerCharacter);

// FIXME: We should invoke checkAnchorStatus actively when layout, scroll,

« no previous file with comments | « no previous file | public/web/WebViewClient.h » ('j') | no next file with comments »