Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 557613002: Remove a part of type checking predicates of HTMLInputElement. (Closed)

Created:
6 years, 3 months ago by tkent
Modified:
6 years, 3 months ago
Reviewers:
keishi
CC:
blink-reviews, eae+blinkwatch, dcheng, apavlov+blink_chromium.org, aandrey+blink_chromium.org, rune+blink, caseq+blink_chromium.org, aboxhall, blink-reviews-events_chromium.org, malch+blink_chromium.org, blink-reviews-html_chromium.org, yurys+blink_chromium.org, dglazkov+blink, gavinp+loader_chromium.org, jchaffraix+rendering, devtools-reviews_chromium.org, pdr., loislo+blink_chromium.org, zoltan1, lushnikov+blink_chromium.org, eustas+blink_chromium.org, paulirish+reviews_chromium.org, Nate Chapin, blink-reviews-rendering, leviw+renderwatch, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, dmazzoni, sergeyv+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

Remove a part of type checking predicates of HTMLInputElement. Use |type() == InputTypeNames:foo| instead. These predicates are inconsistent and confusing. BUG= TEST=none; No behavior changes. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181598

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -407 lines) Patch
M Source/core/accessibility/AXNodeObject.cpp View 10 chunks +14 lines, -15 lines 0 comments Download
M Source/core/accessibility/AXRenderObject.cpp View 3 chunks +6 lines, -11 lines 0 comments Download
M Source/core/editing/FrameSelection.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/editing/ReplaceSelectionCommand.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/html/HTMLInputElement.h View 1 chunk +4 lines, -20 lines 0 comments Download
M Source/core/html/HTMLInputElement.cpp View 13 chunks +20 lines, -96 lines 0 comments Download
M Source/core/html/RadioNodeList.cpp View 3 chunks +3 lines, -2 lines 0 comments Download
M Source/core/html/forms/CheckboxInputType.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/forms/CheckboxInputType.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/html/forms/ColorInputType.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/forms/ColorInputType.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/html/forms/DateInputType.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/forms/DateInputType.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/html/forms/DateTimeLocalInputType.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/forms/DateTimeLocalInputType.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/html/forms/EmailInputType.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/forms/EmailInputType.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/html/forms/FileInputType.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/forms/FileInputType.cpp View 2 chunks +1 line, -6 lines 0 comments Download
M Source/core/html/forms/HiddenInputType.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/forms/HiddenInputType.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/html/forms/ImageInputType.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/forms/ImageInputType.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/html/forms/InputType.h View 1 chunk +0 lines, -18 lines 0 comments Download
M Source/core/html/forms/InputType.cpp View 3 chunks +0 lines, -90 lines 0 comments Download
M Source/core/html/forms/MonthInputType.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/forms/MonthInputType.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/html/forms/NumberInputType.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/forms/NumberInputType.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/html/forms/PasswordInputType.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/forms/PasswordInputType.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/html/forms/RadioButtonGroupScope.cpp View 11 chunks +11 lines, -10 lines 0 comments Download
M Source/core/html/forms/RadioInputType.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/forms/RadioInputType.cpp View 4 chunks +3 lines, -8 lines 0 comments Download
M Source/core/html/forms/RangeInputType.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/forms/RangeInputType.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/html/forms/SearchInputType.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/forms/SearchInputType.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/html/forms/TelephoneInputType.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/forms/TelephoneInputType.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/html/forms/TimeInputType.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/forms/TimeInputType.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/html/forms/URLInputType.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/forms/URLInputType.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/html/forms/WeekInputType.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/forms/WeekInputType.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/inspector/InspectorDOMAgent.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/loader/FormSubmission.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/page/DragController.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/page/EventHandler.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/page/PageSerializer.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/rendering/RenderFileUploadControl.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/rendering/RenderSearchField.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/rendering/RenderSlider.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/rendering/RenderTextControlSingleLine.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/rendering/RenderTheme.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/ContextMenuClientImpl.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M Source/web/WebInputElement.cpp View 2 chunks +6 lines, -5 lines 0 comments Download
M Source/web/WebSearchableFormData.cpp View 3 chunks +3 lines, -2 lines 0 comments Download
M Source/web/WebViewImpl.cpp View 2 chunks +14 lines, -12 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
tkent
Keishi, would you review this please?
6 years, 3 months ago (2014-09-09 01:53:05 UTC) #2
keishi
lgtm
6 years, 3 months ago (2014-09-09 02:59:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/557613002/1
6 years, 3 months ago (2014-09-09 03:13:45 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-09 03:18:39 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as 181598

Powered by Google App Engine
This is Rietveld 408576698