Source/core/editing/FrameSelection.cpp - Issue 557613002: Remove a part of type checking predicates of HTMLInputElement.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/FrameSelection.cpp

Issue 557613002: Remove a part of type checking predicates of HTMLInputElement. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/editing/FrameSelection.cpp

diff --git a/Source/core/editing/FrameSelection.cpp b/Source/core/editing/FrameSelection.cpp

index 7fe3bc1e826e82316cbefce7fcf18192ebe7e693..3ed06bd5230897b9b7b542d23d353ef9c3b3b70b 100644

--- a/Source/core/editing/FrameSelection.cpp

+++ b/Source/core/editing/FrameSelection.cpp

@@ -28,6 +28,7 @@

#include "bindings/core/v8/ExceptionState.h"

#include "core/HTMLNames.h"

+#include "core/InputTypeNames.h"

#include "core/accessibility/AXObjectCache.h"

#include "core/css/StylePropertySet.h"

#include "core/dom/CharacterData.h"

@@ -1432,7 +1433,7 @@ PassRefPtrWillBeRawPtr<Range> FrameSelection::firstRange() const

bool FrameSelection::isInPasswordField() const

{

HTMLTextFormControlElement* textControl = enclosingTextFormControl(start());

- return isHTMLInputElement(textControl) && toHTMLInputElement(textControl)->isPasswordField();

+ return isHTMLInputElement(textControl) && toHTMLInputElement(textControl)->type() == InputTypeNames::password;

}

void FrameSelection::notifyAccessibilityForSelectionChange()