Source/web/ContextMenuClientImpl.cpp - Issue 557613002: Remove a part of type checking predicates of HTMLInputElement.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/ContextMenuClientImpl.cpp

Issue 557613002: Remove a part of type checking predicates of HTMLInputElement. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/ContextMenuClientImpl.cpp

diff --git a/Source/web/ContextMenuClientImpl.cpp b/Source/web/ContextMenuClientImpl.cpp

index de1fc6997af5e27f501dd2488d29e824a21b945d..d4f7d719e6038c91531876ce6fbd5eb80d629159 100644

--- a/Source/web/ContextMenuClientImpl.cpp

+++ b/Source/web/ContextMenuClientImpl.cpp

@@ -34,6 +34,7 @@

#include "bindings/core/v8/ExceptionStatePlaceholder.h"

#include "core/CSSPropertyNames.h"

#include "core/HTMLNames.h"

+#include "core/InputTypeNames.h"

#include "core/css/CSSStyleDeclaration.h"

#include "core/dom/Document.h"

#include "core/dom/DocumentMarkerController.h"

@@ -312,7 +313,7 @@ void ContextMenuClientImpl::showContextMenu(const ContextMenu* defaultMenu)

}

if (r.isSelected()) {

- if (!isHTMLInputElement(*r.innerNonSharedNode()) || !toHTMLInputElement(r.innerNonSharedNode())->isPasswordField())

+ if (!isHTMLInputElement(*r.innerNonSharedNode()) || toHTMLInputElement(r.innerNonSharedNode())->type() != InputTypeNames::password)

data.selectedText = selectedFrame->selectedText().stripWhiteSpace();

}

« no previous file with comments | « Source/core/rendering/RenderTheme.cpp ('k') | Source/web/WebInputElement.cpp » ('j') | no next file with comments »