Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 556933002: Remove protobuf lite for java. (Closed)

Created:
6 years, 3 months ago by nyquist
Modified:
6 years, 3 months ago
Reviewers:
Yaron, Nicolas Zea, brettw
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove protobuf lite for java. Since the introduction of nano protobufs for Java in https://codereview.chromium.org/532303003 (and updated in https://codereview.chromium.org/549543002), there is no need for the lite protocol buffers anymore. This CL removes the checked out files initially introduced when protobuf lite support for Java was added in https://chromiumcodereview.appspot.com/11347026 and cleans up the infrastructure regarding generating protocol buffers. Since lite is not supported anymore, this also removes the requirement for setting the 'proto_runtime' variable for targets using build/protoc_java.gypi. BUG=377891 TBR=zea@chromium.org Committed: https://crrev.com/cca2bcd58f7fe1ef6100265c0d2f40e9c5e23f8c Cr-Commit-Position: refs/heads/master@{#294453}

Patch Set 1 #

Patch Set 2 : no changes? #

Patch Set 3 : Rebase before submit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -34662 lines) Patch
M build/protoc_java.gypi View 1 2 3 chunks +5 lines, -25 lines 0 comments Download
M build/protoc_java.py View 1 2 4 chunks +8 lines, -16 lines 0 comments Download
M third_party/cacheinvalidation/cacheinvalidation.gyp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/protobuf/README.chromium View 1 2 2 chunks +0 lines, -11 lines 0 comments Download
D third_party/protobuf/java/README.txt View 1 2 1 chunk +0 lines, -96 lines 0 comments Download
D third_party/protobuf/java/pom.xml View 1 2 1 chunk +0 lines, -205 lines 0 comments Download
D third_party/protobuf/java/src/main/java/com/google/protobuf/AbstractMessage.java View 1 2 1 chunk +0 lines, -930 lines 0 comments Download
D third_party/protobuf/java/src/main/java/com/google/protobuf/AbstractMessageLite.java View 1 2 1 chunk +0 lines, -343 lines 0 comments Download
D third_party/protobuf/java/src/main/java/com/google/protobuf/AbstractParser.java View 1 2 1 chunk +0 lines, -261 lines 0 comments Download
D third_party/protobuf/java/src/main/java/com/google/protobuf/BlockingRpcChannel.java View 1 2 1 chunk +0 lines, -51 lines 0 comments Download
D third_party/protobuf/java/src/main/java/com/google/protobuf/BlockingService.java View 1 2 1 chunk +0 lines, -64 lines 0 comments Download
D third_party/protobuf/java/src/main/java/com/google/protobuf/BoundedByteString.java View 1 2 1 chunk +0 lines, -163 lines 0 comments Download
D third_party/protobuf/java/src/main/java/com/google/protobuf/ByteString.java View 1 2 1 chunk +0 lines, -970 lines 0 comments Download
D third_party/protobuf/java/src/main/java/com/google/protobuf/CodedInputStream.java View 1 2 1 chunk +0 lines, -920 lines 0 comments Download
D third_party/protobuf/java/src/main/java/com/google/protobuf/CodedOutputStream.java View 1 2 1 chunk +0 lines, -1111 lines 0 comments Download
D third_party/protobuf/java/src/main/java/com/google/protobuf/Descriptors.java View 1 2 1 chunk +0 lines, -1970 lines 0 comments Download
D third_party/protobuf/java/src/main/java/com/google/protobuf/DynamicMessage.java View 1 2 1 chunk +0 lines, -482 lines 0 comments Download
D third_party/protobuf/java/src/main/java/com/google/protobuf/ExtensionRegistry.java View 1 2 1 chunk +0 lines, -266 lines 0 comments Download
D third_party/protobuf/java/src/main/java/com/google/protobuf/ExtensionRegistryLite.java View 1 2 1 chunk +0 lines, -185 lines 0 comments Download
D third_party/protobuf/java/src/main/java/com/google/protobuf/FieldSet.java View 1 2 1 chunk +0 lines, -861 lines 0 comments Download
D third_party/protobuf/java/src/main/java/com/google/protobuf/GeneratedMessage.java View 1 2 1 chunk +0 lines, -1939 lines 0 comments Download
D third_party/protobuf/java/src/main/java/com/google/protobuf/GeneratedMessageLite.java View 1 2 1 chunk +0 lines, -797 lines 0 comments Download
D third_party/protobuf/java/src/main/java/com/google/protobuf/Internal.java View 1 2 1 chunk +0 lines, -153 lines 0 comments Download
D third_party/protobuf/java/src/main/java/com/google/protobuf/InvalidProtocolBufferException.java View 1 2 1 chunk +0 lines, -114 lines 0 comments Download
D third_party/protobuf/java/src/main/java/com/google/protobuf/LazyField.java View 1 2 1 chunk +0 lines, -210 lines 0 comments Download
D third_party/protobuf/java/src/main/java/com/google/protobuf/LazyStringArrayList.java View 1 2 1 chunk +0 lines, -178 lines 0 comments Download
D third_party/protobuf/java/src/main/java/com/google/protobuf/LazyStringList.java View 1 2 1 chunk +0 lines, -81 lines 0 comments Download
D third_party/protobuf/java/src/main/java/com/google/protobuf/LiteralByteString.java View 1 2 1 chunk +0 lines, -349 lines 0 comments Download
D third_party/protobuf/java/src/main/java/com/google/protobuf/Message.java View 1 2 1 chunk +0 lines, -237 lines 0 comments Download
D third_party/protobuf/java/src/main/java/com/google/protobuf/MessageLite.java View 1 2 1 chunk +0 lines, -319 lines 0 comments Download
D third_party/protobuf/java/src/main/java/com/google/protobuf/MessageLiteOrBuilder.java View 1 2 1 chunk +0 lines, -60 lines 0 comments Download
D third_party/protobuf/java/src/main/java/com/google/protobuf/MessageOrBuilder.java View 1 2 1 chunk +0 lines, -129 lines 0 comments Download
D third_party/protobuf/java/src/main/java/com/google/protobuf/Parser.java View 1 2 1 chunk +0 lines, -259 lines 0 comments Download
D third_party/protobuf/java/src/main/java/com/google/protobuf/ProtocolMessageEnum.java View 1 2 1 chunk +0 lines, -58 lines 0 comments Download
D third_party/protobuf/java/src/main/java/com/google/protobuf/RepeatedFieldBuilder.java View 1 2 1 chunk +0 lines, -696 lines 0 comments Download
D third_party/protobuf/java/src/main/java/com/google/protobuf/RopeByteString.java View 1 2 1 chunk +0 lines, -943 lines 0 comments Download
D third_party/protobuf/java/src/main/java/com/google/protobuf/RpcCallback.java View 1 2 1 chunk +0 lines, -47 lines 0 comments Download
D third_party/protobuf/java/src/main/java/com/google/protobuf/RpcChannel.java View 1 2 1 chunk +0 lines, -71 lines 0 comments Download
D third_party/protobuf/java/src/main/java/com/google/protobuf/RpcController.java View 1 2 1 chunk +0 lines, -118 lines 0 comments Download
D third_party/protobuf/java/src/main/java/com/google/protobuf/RpcUtil.java View 1 2 1 chunk +0 lines, -135 lines 0 comments Download
D third_party/protobuf/java/src/main/java/com/google/protobuf/Service.java View 1 2 1 chunk +0 lines, -117 lines 0 comments Download
D third_party/protobuf/java/src/main/java/com/google/protobuf/ServiceException.java View 1 2 1 chunk +0 lines, -52 lines 0 comments Download
D third_party/protobuf/java/src/main/java/com/google/protobuf/SingleFieldBuilder.java View 1 2 1 chunk +0 lines, -241 lines 0 comments Download
D third_party/protobuf/java/src/main/java/com/google/protobuf/SmallSortedMap.java View 1 2 1 chunk +0 lines, -618 lines 0 comments Download
D third_party/protobuf/java/src/main/java/com/google/protobuf/TextFormat.java View 1 2 1 chunk +0 lines, -1559 lines 0 comments Download
D third_party/protobuf/java/src/main/java/com/google/protobuf/UninitializedMessageException.java View 1 2 1 chunk +0 lines, -99 lines 0 comments Download
D third_party/protobuf/java/src/main/java/com/google/protobuf/UnknownFieldSet.java View 1 2 1 chunk +0 lines, -978 lines 0 comments Download
D third_party/protobuf/java/src/main/java/com/google/protobuf/UnmodifiableLazyStringList.java View 1 2 1 chunk +0 lines, -152 lines 0 comments Download
D third_party/protobuf/java/src/main/java/com/google/protobuf/Utf8.java View 1 2 1 chunk +0 lines, -349 lines 0 comments Download
D third_party/protobuf/java/src/main/java/com/google/protobuf/WireFormat.java View 1 2 1 chunk +0 lines, -163 lines 0 comments Download
D third_party/protobuf/java/src/test/java/com/google/protobuf/AbstractMessageTest.java View 1 2 1 chunk +0 lines, -509 lines 0 comments Download
D third_party/protobuf/java/src/test/java/com/google/protobuf/BoundedByteStringTest.java View 1 2 1 chunk +0 lines, -68 lines 0 comments Download
D third_party/protobuf/java/src/test/java/com/google/protobuf/ByteStringTest.java View 1 2 1 chunk +0 lines, -692 lines 0 comments Download
D third_party/protobuf/java/src/test/java/com/google/protobuf/CodedInputStreamTest.java View 1 2 1 chunk +0 lines, -528 lines 0 comments Download
D third_party/protobuf/java/src/test/java/com/google/protobuf/CodedOutputStreamTest.java View 1 2 1 chunk +0 lines, -317 lines 0 comments Download
D third_party/protobuf/java/src/test/java/com/google/protobuf/DeprecatedFieldTest.java View 1 2 1 chunk +0 lines, -80 lines 0 comments Download
D third_party/protobuf/java/src/test/java/com/google/protobuf/DescriptorsTest.java View 1 2 1 chunk +0 lines, -648 lines 0 comments Download
D third_party/protobuf/java/src/test/java/com/google/protobuf/DynamicMessageTest.java View 1 2 1 chunk +0 lines, -264 lines 0 comments Download
D third_party/protobuf/java/src/test/java/com/google/protobuf/ForceFieldBuildersPreRun.java View 1 2 1 chunk +0 lines, -48 lines 0 comments Download
D third_party/protobuf/java/src/test/java/com/google/protobuf/GeneratedMessageTest.java View 1 2 1 chunk +0 lines, -1146 lines 0 comments Download
D third_party/protobuf/java/src/test/java/com/google/protobuf/IsValidUtf8Test.java View 1 2 1 chunk +0 lines, -180 lines 0 comments Download
D third_party/protobuf/java/src/test/java/com/google/protobuf/IsValidUtf8TestUtil.java View 1 2 1 chunk +0 lines, -421 lines 0 comments Download
D third_party/protobuf/java/src/test/java/com/google/protobuf/LazyStringArrayListTest.java View 1 2 1 chunk +0 lines, -162 lines 0 comments Download
D third_party/protobuf/java/src/test/java/com/google/protobuf/LazyStringEndToEndTest.java View 1 2 1 chunk +0 lines, -143 lines 0 comments Download
D third_party/protobuf/java/src/test/java/com/google/protobuf/LiteTest.java View 1 2 1 chunk +0 lines, -148 lines 0 comments Download
D third_party/protobuf/java/src/test/java/com/google/protobuf/LiteralByteStringTest.java View 1 2 1 chunk +0 lines, -396 lines 0 comments Download
D third_party/protobuf/java/src/test/java/com/google/protobuf/MessageTest.java View 1 2 1 chunk +0 lines, -353 lines 0 comments Download
D third_party/protobuf/java/src/test/java/com/google/protobuf/NestedBuildersTest.java View 1 2 1 chunk +0 lines, -185 lines 0 comments Download
D third_party/protobuf/java/src/test/java/com/google/protobuf/ParserTest.java View 1 2 1 chunk +0 lines, -375 lines 0 comments Download
D third_party/protobuf/java/src/test/java/com/google/protobuf/RepeatedFieldBuilderTest.java View 1 2 1 chunk +0 lines, -190 lines 0 comments Download
D third_party/protobuf/java/src/test/java/com/google/protobuf/RopeByteStringSubstringTest.java View 1 2 1 chunk +0 lines, -97 lines 0 comments Download
D third_party/protobuf/java/src/test/java/com/google/protobuf/RopeByteStringTest.java View 1 2 1 chunk +0 lines, -115 lines 0 comments Download
D third_party/protobuf/java/src/test/java/com/google/protobuf/ServiceTest.java View 1 2 1 chunk +0 lines, -320 lines 0 comments Download
D third_party/protobuf/java/src/test/java/com/google/protobuf/SingleFieldBuilderTest.java View 1 2 1 chunk +0 lines, -155 lines 0 comments Download
D third_party/protobuf/java/src/test/java/com/google/protobuf/SmallSortedMapTest.java View 1 2 1 chunk +0 lines, -420 lines 0 comments Download
D third_party/protobuf/java/src/test/java/com/google/protobuf/TestBadIdentifiers.java View 1 2 1 chunk +0 lines, -63 lines 0 comments Download
D third_party/protobuf/java/src/test/java/com/google/protobuf/TestUtil.java View 1 2 1 chunk +0 lines, -3955 lines 0 comments Download
D third_party/protobuf/java/src/test/java/com/google/protobuf/TextFormatTest.java View 1 2 1 chunk +0 lines, -786 lines 0 comments Download
D third_party/protobuf/java/src/test/java/com/google/protobuf/UnknownFieldSetTest.java View 1 2 1 chunk +0 lines, -437 lines 0 comments Download
D third_party/protobuf/java/src/test/java/com/google/protobuf/UnmodifiableLazyStringListTest.java View 1 2 1 chunk +0 lines, -152 lines 0 comments Download
D third_party/protobuf/java/src/test/java/com/google/protobuf/WireFormatTest.java View 1 2 1 chunk +0 lines, -580 lines 0 comments Download
D third_party/protobuf/java/src/test/java/com/google/protobuf/multiple_files_test.proto View 1 2 1 chunk +0 lines, -71 lines 0 comments Download
D third_party/protobuf/java/src/test/java/com/google/protobuf/nested_builders_test.proto View 1 2 1 chunk +0 lines, -53 lines 0 comments Download
D third_party/protobuf/java/src/test/java/com/google/protobuf/nested_extension.proto View 1 2 1 chunk +0 lines, -45 lines 0 comments Download
D third_party/protobuf/java/src/test/java/com/google/protobuf/nested_extension_lite.proto View 1 2 1 chunk +0 lines, -48 lines 0 comments Download
D third_party/protobuf/java/src/test/java/com/google/protobuf/non_nested_extension.proto View 1 2 1 chunk +0 lines, -48 lines 0 comments Download
D third_party/protobuf/java/src/test/java/com/google/protobuf/non_nested_extension_lite.proto View 1 2 1 chunk +0 lines, -50 lines 0 comments Download
D third_party/protobuf/java/src/test/java/com/google/protobuf/test_bad_identifiers.proto View 1 2 1 chunk +0 lines, -108 lines 0 comments Download
M third_party/protobuf/protobuf.gyp View 1 2 1 chunk +0 lines, -48 lines 0 comments Download
D third_party/protobuf/protobuf_lite_java_descriptor_proto.py View 1 2 1 chunk +0 lines, -49 lines 0 comments Download
D third_party/protobuf/protobuf_lite_java_parse_pom.py View 1 2 1 chunk +0 lines, -57 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
nyquist
yfriedman: PTAL
6 years, 3 months ago (2014-09-09 18:46:14 UTC) #2
Yaron
lgtm
6 years, 3 months ago (2014-09-09 18:55:11 UTC) #4
nyquist
brettw: third_party/protobuf zea: third_party/cacheinvalidation
6 years, 3 months ago (2014-09-09 20:31:28 UTC) #7
brettw
rs lgtm
6 years, 3 months ago (2014-09-09 20:37:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/556933002/20001
6 years, 3 months ago (2014-09-11 18:44:18 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:20001) as d4c45be0368ecc7dc567a0ee6baf12892d4b4402
6 years, 3 months ago (2014-09-11 20:13:51 UTC) #13
commit-bot: I haz the power
6 years, 3 months ago (2014-09-11 20:19:37 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/cca2bcd58f7fe1ef6100265c0d2f40e9c5e23f8c
Cr-Commit-Position: refs/heads/master@{#294453}

Powered by Google App Engine
This is Rietveld 408576698