Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Issue 532303003: Add support for Java nano protocol buffers for Android (take 2). (Closed)

Created:
6 years, 3 months ago by nyquist
Modified:
6 years, 3 months ago
CC:
chromium-reviews, Lei Zhang
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add support for Java nano protocol buffers for Android (take 2). This CL adds a new dependency on the protocol buffer compiler from the android source tree, since this compiler supports generating Java files using the nano runtime. The initial version of this dependency is 2.2.0a, but checked out as what the Android 4.4.4 Release 2.0.1 tag points to. This CL adds a new protoc binary (for compiling protos) that supports this, and also adds a Java library with the runtime. To simplify use of this, it also updates build/protoc_java.gypi to support generating nano protos by specifying an optional proto_runtime argument. The argument defaults to 'lite' which does the same thing as before this change, and setting it to 'nano' generates the new style Java files. The plan is to quickly deprecate the 'lite' runtime for Java, since it is too big and uses too many methods. TBR=darin@chromium.org,cjhopman@chromium.org BUG=377891, 410067 Committed: https://crrev.com/38f28ba65426989765f8d070ef5f64b5fbce23fa Cr-Commit-Position: refs/heads/master@{#293236}

Patch Set 1 #

Patch Set 2 : Updated to use chromium mirror #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+218 lines, -17 lines) Patch
M .gitignore View 1 chunk +1 line, -0 lines 0 comments Download
M DEPS View 1 1 chunk +3 lines, -0 lines 0 comments Download
M build/protoc_java.gypi View 3 chunks +25 lines, -5 lines 0 comments Download
M build/protoc_java.py View 3 chunks +23 lines, -11 lines 0 comments Download
A + third_party/android_protobuf/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
A third_party/android_protobuf/README.chromium View 1 chunk +29 lines, -0 lines 1 comment Download
A third_party/android_protobuf/android_protobuf.gyp View 1 chunk +137 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
nyquist
TBRin darin and cjhopman. Patch set 1 is original patch. Patch set 2 is the ...
6 years, 3 months ago (2014-09-03 20:52:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nyquist@chromium.org/532303003/20001
6 years, 3 months ago (2014-09-03 21:01:13 UTC) #4
cjhopman
lgtm
6 years, 3 months ago (2014-09-03 21:14:17 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as a94f6dad963342ac1ec13f6c317e0810ce0ddfe2
6 years, 3 months ago (2014-09-04 00:29:40 UTC) #6
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/38f28ba65426989765f8d070ef5f64b5fbce23fa Cr-Commit-Position: refs/heads/master@{#293236}
6 years, 3 months ago (2014-09-10 03:29:02 UTC) #7
Lei Zhang
6 years, 3 months ago (2014-09-23 21:42:57 UTC) #8
Message was sent while issue was closed.
https://codereview.chromium.org/532303003/diff/20001/third_party/android_prot...
File third_party/android_protobuf/README.chromium (right):

https://codereview.chromium.org/532303003/diff/20001/third_party/android_prot...
third_party/android_protobuf/README.chromium:10: Name:
It's weird to have 2 set of entries in the same README.chromium file.
tools/licenses.py doesn't understand this and will only pick up the first entry
and put it in about:credits.

Powered by Google App Engine
This is Rietveld 408576698