Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(983)

Issue 549543002: Updating android_protobuf to L-preview branch to support the optional_field_style=reftypes flag. Th… (Closed)

Created:
6 years, 3 months ago by Colin Meek
Modified:
6 years, 3 months ago
Reviewers:
nyquist
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Updating android_protobuf to L-preview branch Adding support for the optional_field_style=reftypes flag. This is needed for the invalidation client which expects "boxed" types (e.g., Boolean rather than boolean) for primitive fields, and depends on null comparisons to determine whether or not a field is set. BUG=377891, 411282 R=nyquist@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/e0995c041b77d1c08e7652f44de918b275efbd0b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M third_party/android_protobuf/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/android_protobuf/README.chromium View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
Colin Meek
6 years, 3 months ago (2014-09-05 18:05:15 UTC) #2
nyquist
lgtm could you wrap at around 70 chars? also, keep the first line as a ...
6 years, 3 months ago (2014-09-05 18:07:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/meek@chromium.org/549543002/1
6 years, 3 months ago (2014-09-05 18:12:46 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/2536)
6 years, 3 months ago (2014-09-05 19:14:15 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/meek@chromium.org/549543002/1
6 years, 3 months ago (2014-09-05 19:41:26 UTC) #11
nyquist
Committed patchset #1 (id:1) manually as e0995c0 (presubmit successful).
6 years, 3 months ago (2014-09-05 22:01:42 UTC) #12
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:41:37 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e0995c041b77d1c08e7652f44de918b275efbd0b
Cr-Commit-Position: refs/heads/master@{#293583}

Powered by Google App Engine
This is Rietveld 408576698