Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 556913002: Use reference instead of pointer in BMPImageDecoder::processFileHeader (Closed)

Created:
6 years, 3 months ago by deepak.sa
Modified:
6 years, 3 months ago
Reviewers:
tkent, esprehn
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Use reference instead of pointer in BMPImageDecoder::processFileHeader Use reference instead of pointer in BMPImageDecoder::processFileHeader Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181777

Patch Set 1 #

Patch Set 2 : Assert removed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -9 lines) Patch
M Source/platform/image-decoders/bmp/BMPImageDecoder.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/platform/image-decoders/bmp/BMPImageDecoder.cpp View 1 2 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
deepak.sa
PTAL? Thanks!
6 years, 3 months ago (2014-09-10 08:32:19 UTC) #2
tkent
lgtm
6 years, 3 months ago (2014-09-10 23:36:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/556913002/20001
6 years, 3 months ago (2014-09-10 23:37:26 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-11 01:27:24 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 181777

Powered by Google App Engine
This is Rietveld 408576698