Use reference instead of pointer in BMPImageDecoder::processFileHeader

Source/platform/image-decoders/bmp/BMPImageDecoder.cpp

 /*
  * Copyright (c) 2008, 2009, Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 92 matching lines @@
         setFailed();
     // If we're done decoding the image, we don't need the BMPImageReader
     // anymore.  (If we failed, |m_reader| has already been cleared.)
     else if (!m_frameBufferCache.isEmpty() && (m_frameBufferCache.first().status() == ImageFrame::FrameComplete))
         m_reader.clear();
 }
 
 bool BMPImageDecoder::decodeHelper(bool onlySize)
 {
     size_t imgDataOffset = 0;
-    if ((m_decodedOffset < sizeOfFileHeader) && !processFileHeader(&imgDataOffset))
+    if ((m_decodedOffset < sizeOfFileHeader) && !processFileHeader(imgDataOffset))
         return false;
 
     if (!m_reader) {
         m_reader = adoptPtr(new BMPImageReader(this, m_decodedOffset, imgDataOffset, false));
         m_reader->setData(m_data.get());
     }
 
     if (!m_frameBufferCache.isEmpty())
         m_reader->setBuffer(&m_frameBufferCache.first());
 
     return m_reader->decodeBMP(onlySize);
 }
 
-bool BMPImageDecoder::processFileHeader(size_t* imgDataOffset)
+bool BMPImageDecoder::processFileHeader(size_t& imgDataOffset)
 {
-    ASSERT(imgDataOffset);
-
     // Read file header.
     ASSERT(!m_decodedOffset);
     if (m_data->size() < sizeOfFileHeader)
         return false;
     const uint16_t fileType = (m_data->data()[0] << 8) | static_cast<uint8_t>(m_data->data()[1]);
-    *imgDataOffset = readUint32(10);
+    imgDataOffset = readUint32(10);
     m_decodedOffset = sizeOfFileHeader;
 
     // See if this is a bitmap filetype we understand.
     enum {
         BMAP = 0x424D,  // "BM"
         // The following additional OS/2 2.x header values (see
         // http://www.fileformat.info/format/os2bmp/egff.htm ) aren't widely
         // decoded, and are unlikely to be in much use.
         /*
         ICON = 0x4943,  // "IC"
         POINTER = 0x5054,  // "PT"
         COLORICON = 0x4349,  // "CI"
         COLORPOINTER = 0x4350,  // "CP"
         BITMAPARRAY = 0x4241,  // "BA"
         */
     };
     return (fileType == BMAP) || setFailed();
 }
 
 } // namespace blink